commit 80214c6325ca2cd8a91d522d40c9b294e3078948
author Shubham Sharma <shubham.sharma45@infosys.com> Wed Dec 18 07:09:59 2019 +0000
committer Jonathan Hart <jonomhart@gmail.com> Tue Jan 28 11:58:32 2020 -0800
tree 003474362ef43a291f41f8995fab41cb9c470b87
parent 2b3fb697d49023c94cdf06a51aaa4facc7533b79

[SEBA-905] Fix Assertions in Unit Test cases for authentication statistics

Change-Id: I6a4277492e424409b609fdbbadb284f1a13f3812
(cherry picked from commit 1bd890d550a107d53f58d99177966ce19196feb1)

app/src/test/java/org/opencord/aaa/impl/AaaStatisticsTest.java

diff --git a/app/src/test/java/org/opencord/aaa/impl/AaaStatisticsTest.java b/app/src/test/java/org/opencord/aaa/impl/AaaStatisticsTest.java
index 66e50f2..5c9f657 100644
--- a/app/src/test/java/org/opencord/aaa/impl/AaaStatisticsTest.java
+++ b/app/src/test/java/org/opencord/aaa/impl/AaaStatisticsTest.java
@@ -319,9 +319,15 @@
         assertNotEquals(aaaStatisticsManager.getAaaStats().getEapolTransRespNotNak(), ZERO);
         assertNotEquals(aaaStatisticsManager.getAaaStats().getEapPktTxauthChooseEap(), ZERO);
 
-       // Counts the aaa Statistics count and displays in the log
-       countAaaStatistics();
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getAcceptResponsesRx(), ZERO);
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getAccessRequestsTx(), ZERO);
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getChallengeResponsesRx(), ZERO);
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getDroppedResponsesRx(), ZERO);
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getInvalidValidatorsRx(), ZERO);
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getPendingRequests(), ZERO);
 
+        // Counts the aaa Statistics count and displays in the log
+        countAaaStatistics();
     }
 
     /** Tests the count for defected packets.
@@ -386,6 +392,15 @@
         assertNotEquals(aaaStatisticsManager.getAaaStats().getEapPktTxauthChooseEap(), ZERO);
         assertNotEquals(aaaStatisticsManager.getAaaStats().getEapolTransRespNotNak(), ZERO);
 
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getAccessRequestsTx(), ZERO);
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getChallengeResponsesRx(), ZERO);
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getDroppedResponsesRx(), ZERO);
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getInvalidValidatorsRx(), ZERO);
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getPendingRequests(), ZERO);
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getRejectResponsesRx(), ZERO);
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getRequestRttMilis(), ZERO);
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getUnknownTypeRx(), ZERO);
+
         // Counts the aaa Statistics count
         countAaaStatistics();
 
@@ -430,9 +445,16 @@
         assertNotEquals(aaaStatisticsManager.getAaaStats().getEapolResIdentityMsgTrans(), ZERO);
         assertNotEquals(aaaStatisticsManager.getAaaStats().getEapolStartReqTrans(), ZERO);
 
-        countAaaStatistics();
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getAccessRequestsTx(), ZERO);
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getDroppedResponsesRx(), ZERO);
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getPendingRequests(), ZERO);
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getMalformedResponsesRx(), ZERO);
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getRequestReTx(), ZERO);
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getUnknownTypeRx(), ZERO);
+        assertNotEquals(aaaStatisticsManager.getAaaStats().getUnknownServerRx(), ZERO);
 
-     }
+        countAaaStatistics();
+    }
 
     /** Tests the authentication path through the AAA application.
      *  And counts the aaa Stats for logoff transactionXZ.