commit 987441af523ac468255671037f54bd782d8d2169
author Saurav Das <sauravdas@alumni.stanford.edu> Tue Sep 18 16:33:47 2018 -0700
committer Saurav Das <sauravdas@alumni.stanford.edu> Wed Sep 19 14:41:34 2018 -0700
tree da7c86d799dab2bcd791f6e54916414b14712b8c
parent 5db4453e99ff232606a7f0ebb52b0db27443ce76

Adding trace logging to emitted and received packets

Change-Id: Id23be0d7fb70258c5de9900f099575404329746a

src/main/java/org/opencord/aaa/SocketBasedRadiusCommunicator.java

diff --git a/src/main/java/org/opencord/aaa/SocketBasedRadiusCommunicator.java b/src/main/java/org/opencord/aaa/SocketBasedRadiusCommunicator.java
index fd6e495..e402aae 100755
--- a/src/main/java/org/opencord/aaa/SocketBasedRadiusCommunicator.java
+++ b/src/main/java/org/opencord/aaa/SocketBasedRadiusCommunicator.java
@@ -15,7 +15,18 @@
  */
 package org.opencord.aaa;
 
-import com.google.common.util.concurrent.ThreadFactoryBuilder;
+import static org.onosproject.net.packet.PacketPriority.CONTROL;
+import static org.slf4j.LoggerFactory.getLogger;
+
+import java.io.IOException;
+import java.net.DatagramPacket;
+import java.net.DatagramSocket;
+import java.net.InetAddress;
+import java.net.InetSocketAddress;
+import java.net.UnknownHostException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+
 import org.onlab.packet.DeserializationException;
 import org.onlab.packet.EthType;
 import org.onlab.packet.Ethernet;
@@ -28,17 +39,7 @@
 import org.onosproject.net.packet.PacketService;
 import org.slf4j.Logger;
 
-import java.io.IOException;
-import java.net.DatagramPacket;
-import java.net.DatagramSocket;
-import java.net.InetAddress;
-import java.net.InetSocketAddress;
-import java.net.UnknownHostException;
-import java.util.concurrent.ExecutorService;
-import java.util.concurrent.Executors;
-
-import static org.onosproject.net.packet.PacketPriority.CONTROL;
-import static org.slf4j.LoggerFactory.getLogger;
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
 
 /**
  * Handles Socket based communication with the RADIUS server.
@@ -141,10 +142,11 @@
                 }
                 DatagramPacket packet =
                         new DatagramPacket(data, data.length, address, radiusServerPort);
-
+                if (log.isTraceEnabled()) {
+                    log.trace("Sending packet {} to Radius Server {}:{} using socket",
+                              radiusPacket, address, radiusServerPort);
+                }
                 socket.send(packet);
-                log.debug("Packet sent to Radius Server {}:{} using socket",
-                        address, radiusServerPort);
             } catch (UnknownHostException uhe) {
                 log.warn("Unable to resolve host {}", radiusHost);
             }
@@ -157,9 +159,11 @@
     public void handlePacketFromServer(PacketContext context) {
         InboundPacket pkt = context.inPacket();
         Ethernet ethPkt = pkt.parsed();
-
-        log.debug("Skipping Ethernet packet type {}",
-                EthType.EtherType.lookup(ethPkt.getEtherType()));
+        if (log.isTraceEnabled() && ethPkt.getEtherType() != Ethernet.TYPE_LLDP
+                && ethPkt.getEtherType() != Ethernet.TYPE_BSN) {
+            log.trace("Skipping Ethernet packet type {}",
+                      EthType.EtherType.lookup(ethPkt.getEtherType()));
+        }
     }
 
     class RadiusListener implements Runnable {