VOL-376 : Fix for Null Pointer Exception when subscriber is not provisioned
Patchet contains
1. Fix for Null Pointer Exception when subscriber is not provisioned in Sadis
2. README.md updates for Sadis configuration of subscriber and device
3. Correcting log levels of some of the logs
Change-Id: I59270faff77d05013a4313629c60911148533e19
diff --git a/src/main/java/org/opencord/aaa/PortBasedRadiusCommunicator.java b/src/main/java/org/opencord/aaa/PortBasedRadiusCommunicator.java
index 6e256b7..8e93777 100755
--- a/src/main/java/org/opencord/aaa/PortBasedRadiusCommunicator.java
+++ b/src/main/java/org/opencord/aaa/PortBasedRadiusCommunicator.java
@@ -129,7 +129,7 @@
mastershipService.addListener(changeListener);
deviceService.addListener(deviceListener);
- log.error("Created PortBased");
+ log.info("Created PortBased");
}
private void initializeLocalState() {
@@ -142,13 +142,12 @@
if (deviceService.isAvailable(cp.deviceId())) {
radiusServerConnectPoint = cp;
}
- log.warn("RADIUS connectPoint selected is {}", cp);
break;
}
}
}
- log.warn("RADIUS connectPoint in initializeLocalState is {}", radiusServerConnectPoint);
+ log.info("RADIUS connectPoint in initializeLocalState is {}", radiusServerConnectPoint);
if (radiusServerConnectPoint == null) {
log.error("Master of none, can't send radius Message to server");
@@ -248,7 +247,7 @@
SubscriberAndDeviceInformation deviceInfo = subsService.get(serialNo);
if (deviceInfo == null) {
- log.error("No Device found with SN {}", serialNo);
+ log.warn("No Device found with SN {}", serialNo);
return;
}
ipToSnMap.put(deviceInfo.ipAddress(), serialNo);
@@ -325,7 +324,7 @@
}
MacAddress senderMac = subsService.get(serialNo).hardwareIdentifier();
if (senderMac == null) {
- log.error("ARP resolution, MAC address not found for SN {}", serialNo);
+ log.warn("ARP resolution, MAC address not found for SN {}", serialNo);
return;
}