Updates to fix testing

- Don't use tmp, instead put in an /opt/devtools which is optionally
  removed
- Idempotency fixes
- version bumps

Change-Id: Ica3d2371809692bc09780027f0bee49025ac1bee
diff --git a/tasks/shellcheck.yml b/tasks/shellcheck.yml
index deeb6d0..d163a5e 100644
--- a/tasks/shellcheck.yml
+++ b/tasks/shellcheck.yml
@@ -8,26 +8,19 @@
   get_url:
     url: "{{ devtools_shellcheck_url }}"
     checksum: "{{ devtools_shellcheck_checksum }}"
-    dest: "/tmp/shellcheck.tar.xz"
+    dest: "{{ devtools_dist_dir }}/shellcheck.tar.xz"
 
 - name: Unarchive shellcheck
   unarchive:
-    src: "/tmp/shellcheck.tar.xz"
-    dest: "/tmp"
+    src: "{{ devtools_dist_dir }}/shellcheck.tar.xz"
+    dest: "{{ devtools_dist_dir }}"
     remote_src: true
 
 - name: Install shellcheck binary
   copy:
-    src: "/tmp/shellcheck-v{{ devtools_shellcheck_version }}/shellcheck"
+    src: >-
+      {{ devtools_dist_dir }}/shellcheck-v{{
+      devtools_shellcheck_version }}/shellcheck
     dest: /usr/local/bin/shellcheck
     mode: "0755"
     remote_src: true
-
-# cleanup
-- name: Cleanup shellcheck downloads in /tmp
-  file:
-    path: "/tmp/{{ item }}"
-    state: absent
-  with_items:
-    - shellcheck.tar.xz
-    - "shellcheck-v{{ devtools_shellcheck_version }}"