commit 4e86a8ad660a8088986a8bac6c9d41d2b37ebec6
author Sean Condon <sean@opennetworking.org> Tue Oct 06 11:42:05 2020 +0100
committer Zack Williams <zdw@opennetworking.org> Wed Oct 07 08:10:21 2020 -0700
tree 4951deed7c8c1d31304e1b2d3aec2b2a99de4a42
parent 952bc00ac2e664a891960dfbf047e66a3b43d3d9

Use the npm ansible module instead of commands

Only run npm build steps if install steps have changed

Change-Id: Ib8aee3904b62b85269dc3225418acad96d178aab

tasks/main.yml

diff --git a/tasks/main.yml b/tasks/main.yml
index fc4d7ca..73e55e5 100644
--- a/tasks/main.yml
+++ b/tasks/main.yml
@@ -1,6 +1,5 @@
 ---
 # timesheets tasks/main.yml
-#
 # SPDX-FileCopyrightText: © 2020 Open Networking Foundation <support@opennetworking.org>
 # SPDX-License-Identifier: Apache-2.0
 
@@ -46,16 +45,16 @@
 - name: Install timesheetsdb
   become: true
   become_user: "{{ timesheets_username }}"
-  command:
-    chdir: "{{ timesheets_dir }}/db"
-    cmd: "npm install"
-    creates: "{{ timesheets_dir }}/db/node_modules"
+  npm:
+    path: "{{ timesheets_dir }}/db"
+  register: install_timesheetsdb
   notify:
     - "restart-timesheetsdb"
 
 - name: Build timesheetsdb
   become: true
   become_user: "{{ timesheets_username }}"
+  when: install_timesheetsdb.changed  # noqa 503
   command:
     chdir: "{{ timesheets_dir }}/db"
     cmd: "npm run build"
@@ -82,14 +81,14 @@
 - name: Install timesheetsui
   become: true
   become_user: "{{ timesheets_username }}"
-  command:
-    chdir: "{{ timesheets_dir }}/ui"
-    cmd: "npm install"
-    creates: "{{ timesheets_dir }}/ui/node_modules"
+  npm:
+    path: "{{ timesheets_dir }}/ui"
+  register: install_timesheetsui
 
 - name: Build timesheetsui dist
   become: true
   become_user: "{{ timesheets_username }}"
+  when: install_timesheetsui.changed  # noqa 503
   command:
     chdir: "{{ timesheets_dir }}/ui"
     cmd: "npm run-script ng build --prod"