commit bd7ab46592d3c099159b62be664847100d4e4dc3
author Matteo Scandolo <teo@opennetworking.org> Mon Jun 24 15:27:05 2019 -0700
committer Matteo Scandolo <teo@opennetworking.org> Mon Jun 24 15:27:05 2019 -0700
tree 006c6c87cf4bdc46b020eaa8fee7c225ea44ee08
parent e18b671c95c0f7121a41d762470020840751c4fe

[SEBA-744] Not triggering subscriber model_policies/sync_step if we're only storing the IP

Change-Id: I164cf21ce238a281b14cd4143df253be8adb11ca

xos/synchronizer/model_policies/model_policy_att_workflow_driver_serviceinstance.py

diff --git a/xos/synchronizer/model_policies/model_policy_att_workflow_driver_serviceinstance.py b/xos/synchronizer/model_policies/model_policy_att_workflow_driver_serviceinstance.py
index 10667b1..7dbf07d 100644
--- a/xos/synchronizer/model_policies/model_policy_att_workflow_driver_serviceinstance.py
+++ b/xos/synchronizer/model_policies/model_policy_att_workflow_driver_serviceinstance.py
@@ -206,18 +206,22 @@
         # - the status has changed
         # - we get a DHCPACK event
         if cur_status != subscriber.status or si.dhcp_state == "DHCPACK":
-            self.logger.debug(
-                "MODEL_POLICY: updating subscriber",
-                onu_device=subscriber.onu_device,
-                authentication_state=si.authentication_state,
-                subscriber_status=subscriber.status)
             if subscriber.status == "awaiting-auth":
                 self.delete_subscriber_ip(subscriber, si.ip_address)
                 subscriber.mac_address = ""
             elif si.ip_address and si.mac_address:
                 self.update_subscriber_ip(subscriber, si.ip_address)
                 subscriber.mac_address = si.mac_address
-            subscriber.save_changed_fields(always_update_timestamp=True)
+
+            # NOTE SEBA-744 if the update is a DHCP assignment we don't want to trigger model_policies and sync_steps
+            important_change = (cur_status != subscriber.status)
+            self.logger.debug(
+                "MODEL_POLICY: updating subscriber",
+                onu_device=subscriber.onu_device,
+                authentication_state=si.authentication_state,
+                subscriber_status=subscriber.status,
+                always_update_timestamp=important_change)
+            subscriber.save_changed_fields(always_update_timestamp=important_change)
         else:
             self.logger.debug("MODEL_POLICY: subscriber status has not changed", onu_device=subscriber.onu_device,
                               authentication_state=si.authentication_state, subscriber_status=subscriber.status)