SEBA-497 delayering, Makefile, and tox for att-workflow-drvier
Change-Id: I5869c36b8b716cab02ae12a343969c4feeacf5fb
diff --git a/xos/synchronizer/model_policies/__init__.py b/xos/synchronizer/model_policies/__init__.py
new file mode 100644
index 0000000..19d1424
--- /dev/null
+++ b/xos/synchronizer/model_policies/__init__.py
@@ -0,0 +1,13 @@
+# Copyright 2019-present Open Networking Foundation
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
diff --git a/xos/synchronizer/model_policies/model_policy_att_workflow_driver_serviceinstance.py b/xos/synchronizer/model_policies/model_policy_att_workflow_driver_serviceinstance.py
index 5172830..3b7b74e 100644
--- a/xos/synchronizer/model_policies/model_policy_att_workflow_driver_serviceinstance.py
+++ b/xos/synchronizer/model_policies/model_policy_att_workflow_driver_serviceinstance.py
@@ -14,7 +14,7 @@
# limitations under the License.
-
+from helpers import AttHelpers
from xossynchronizer.model_policies.policy import Policy
import os
@@ -23,11 +23,11 @@
sync_path = os.path.abspath(os.path.join(os.path.dirname(os.path.realpath(__file__)), ".."))
sys.path.append(sync_path)
-from helpers import AttHelpers
class DeferredException(Exception):
pass
+
class AttWorkflowDriverServiceInstancePolicy(Policy):
model_name = "AttWorkflowDriverServiceInstance"
@@ -36,7 +36,8 @@
self.handle_update(si)
def handle_update(self, si):
- self.logger.debug("MODEL_POLICY: handle_update for AttWorkflowDriverServiceInstance %s " % (si.id), onu_state=si.onu_state, authentication_state=si.authentication_state)
+ self.logger.debug("MODEL_POLICY: handle_update for AttWorkflowDriverServiceInstance %s " %
+ (si.id), onu_state=si.onu_state, authentication_state=si.authentication_state)
# Changing ONU state can change auth state
# Changing auth state can change DHCP state
@@ -65,7 +66,7 @@
else:
si.onu_state = "DISABLED"
self.update_onu(si.serial_number, "DISABLED")
- else: # DISABLED
+ else: # DISABLED
if not valid:
si.status_message = message
else:
@@ -118,17 +119,24 @@
# ENABLED | APPROVED | *
# DISABLED | AWAITING | AWAITING
def validate_states(self, si):
- if (si.onu_state == "AWAITING" or si.onu_state == "DISABLED") and si.authentication_state == "AWAITING" and si.dhcp_state == "AWAITING":
+ if (si.onu_state == "AWAITING" or si.onu_state ==
+ "DISABLED") and si.authentication_state == "AWAITING" and si.dhcp_state == "AWAITING":
return
if si.onu_state == "ENABLED" and (si.authentication_state == "APPROVED" or si.dhcp_state == "AWAITING"):
return
- self.logger.warning("MODEL_POLICY (validate_states): invalid state combination", onu_state=si.onu_state, auth_state=si.authentication_state, dhcp_state=si.dhcp_state)
-
+ self.logger.warning(
+ "MODEL_POLICY (validate_states): invalid state combination",
+ onu_state=si.onu_state,
+ auth_state=si.authentication_state,
+ dhcp_state=si.dhcp_state)
def update_onu(self, serial_number, admin_state):
- onu = [onu for onu in self.model_accessor.ONUDevice.objects.all() if onu.serial_number.lower() == serial_number.lower()][0]
+ onu = [onu for onu in self.model_accessor.ONUDevice.objects.all() if onu.serial_number.lower()
+ == serial_number.lower()][0]
if onu.admin_state == admin_state:
- self.logger.debug("MODEL_POLICY: ONUDevice [%s] already has admin_state to %s" % (serial_number, admin_state))
+ self.logger.debug(
+ "MODEL_POLICY: ONUDevice [%s] already has admin_state to %s" %
+ (serial_number, admin_state))
else:
self.logger.debug("MODEL_POLICY: setting ONUDevice [%s] admin_state to %s" % (serial_number, admin_state))
onu.admin_state = admin_state
@@ -136,10 +144,13 @@
def get_subscriber(self, serial_number):
try:
- return [s for s in self.model_accessor.RCORDSubscriber.objects.all() if s.onu_device.lower() == serial_number.lower()][0]
+ return [s for s in self.model_accessor.RCORDSubscriber.objects.all() if s.onu_device.lower()
+ == serial_number.lower()][0]
except IndexError:
# If the subscriber doesn't exist we don't do anything
- self.logger.debug("MODEL_POLICY: subscriber does not exists for this SI, doing nothing", onu_device=serial_number)
+ self.logger.debug(
+ "MODEL_POLICY: subscriber does not exists for this SI, doing nothing",
+ onu_device=serial_number)
return None
def update_subscriber_ip(self, subscriber, ip):
@@ -150,10 +161,15 @@
subscriber_id=subscriber.id,
ip=ip
)[0]
- self.logger.debug("MODEL_POLICY: found existing RCORDIpAddress for subscriber", onu_device=subscriber.onu_device, subscriber_status=subscriber.status, ip=ip)
+ self.logger.debug("MODEL_POLICY: found existing RCORDIpAddress for subscriber",
+ onu_device=subscriber.onu_device, subscriber_status=subscriber.status, ip=ip)
ip.save_changed_fields()
except IndexError:
- self.logger.debug("MODEL_POLICY: Creating new RCORDIpAddress for subscriber", onu_device=subscriber.onu_device, subscriber_status=subscriber.status, ip=ip)
+ self.logger.debug(
+ "MODEL_POLICY: Creating new RCORDIpAddress for subscriber",
+ onu_device=subscriber.onu_device,
+ subscriber_status=subscriber.status,
+ ip=ip)
ip = self.model_accessor.RCORDIpAddress(
subscriber_id=subscriber.id,
ip=ip,
@@ -167,9 +183,13 @@
subscriber_id=subscriber.id,
ip=ip
)[0]
- self.logger.debug("MODEL_POLICY: delete RCORDIpAddress for subscriber", onu_device=subscriber.onu_device, subscriber_status=subscriber.status, ip=ip)
+ self.logger.debug(
+ "MODEL_POLICY: delete RCORDIpAddress for subscriber",
+ onu_device=subscriber.onu_device,
+ subscriber_status=subscriber.status,
+ ip=ip)
ip.delete()
- except:
+ except BaseException:
self.logger.warning("MODEL_POLICY: no RCORDIpAddress object found, cannot delete", ip=ip)
def update_subscriber(self, subscriber, si):
@@ -187,7 +207,11 @@
# - the status has changed
# - we get a DHCPACK event
if cur_status != subscriber.status or si.dhcp_state == "DHCPACK":
- self.logger.debug("MODEL_POLICY: updating subscriber", onu_device=subscriber.onu_device, authentication_state=si.authentication_state, subscriber_status=subscriber.status)
+ self.logger.debug(
+ "MODEL_POLICY: updating subscriber",
+ onu_device=subscriber.onu_device,
+ authentication_state=si.authentication_state,
+ subscriber_status=subscriber.status)
if subscriber.status == "awaiting-auth":
self.delete_subscriber_ip(subscriber, si.ip_address)
subscriber.mac_address = ""
diff --git a/xos/synchronizer/model_policies/model_policy_att_workflow_driver_whitelistentry.py b/xos/synchronizer/model_policies/model_policy_att_workflow_driver_whitelistentry.py
index 2cb0b97..7a31116 100644
--- a/xos/synchronizer/model_policies/model_policy_att_workflow_driver_whitelistentry.py
+++ b/xos/synchronizer/model_policies/model_policy_att_workflow_driver_whitelistentry.py
@@ -14,6 +14,7 @@
# limitations under the License.
+from helpers import AttHelpers
from xossynchronizer.model_policies.policy import Policy
import os
import sys
@@ -21,7 +22,6 @@
sync_path = os.path.abspath(os.path.join(os.path.dirname(os.path.realpath(__file__)), ".."))
sys.path.append(sync_path)
-from helpers import AttHelpers
class AttWorkflowDriverWhiteListEntryPolicy(Policy):
model_name = "AttWorkflowDriverWhiteListEntry"
@@ -39,7 +39,10 @@
si.onu_state = "DISABLED"
self.logger.debug(
- "MODEL_POLICY: activating AttWorkflowDriverServiceInstance because of change in the whitelist", si=si, onu_state=si.onu_state, authentication_state=si.authentication_state)
+ "MODEL_POLICY: activating AttWorkflowDriverServiceInstance because of change in the whitelist",
+ si=si,
+ onu_state=si.onu_state,
+ authentication_state=si.authentication_state)
si.save_changed_fields(always_update_timestamp=True)
def handle_update(self, whitelist):
@@ -55,11 +58,15 @@
self.validate_onu_state(si)
- whitelist.backend_need_delete_policy=True
+ whitelist.backend_need_delete_policy = True
whitelist.save_changed_fields()
def handle_delete(self, whitelist):
- self.logger.debug("MODEL_POLICY: handle_delete for AttWorkflowDriverWhiteListEntry", serial_number=whitelist.serial_number, pon_port=whitelist.pon_port_id, device=whitelist.device_id)
+ self.logger.debug(
+ "MODEL_POLICY: handle_delete for AttWorkflowDriverWhiteListEntry",
+ serial_number=whitelist.serial_number,
+ pon_port=whitelist.pon_port_id,
+ device=whitelist.device_id)
# BUG: Sometimes the delete policy is not called, because the reaper deletes
@@ -71,5 +78,5 @@
for si in sis:
self.validate_onu_state(si)
- whitelist.backend_need_reap=True
+ whitelist.backend_need_reap = True
whitelist.save_changed_fields()
diff --git a/xos/synchronizer/model_policies/test_model_policy_att_workflow_driver_serviceinstance.py b/xos/synchronizer/model_policies/test_model_policy_att_workflow_driver_serviceinstance.py
index 8f803f6..d784258 100644
--- a/xos/synchronizer/model_policies/test_model_policy_att_workflow_driver_serviceinstance.py
+++ b/xos/synchronizer/model_policies/test_model_policy_att_workflow_driver_serviceinstance.py
@@ -15,11 +15,12 @@
import unittest
-from mock import patch, call, Mock, PropertyMock
+from mock import patch
-import os, sys
+import os
+import sys
-test_path=os.path.abspath(os.path.dirname(os.path.realpath(__file__)))
+test_path = os.path.abspath(os.path.dirname(os.path.realpath(__file__)))
class TestModelPolicyAttWorkflowDriverServiceInstance(unittest.TestCase):
@@ -39,24 +40,21 @@
import xossynchronizer.modelaccessor
import mock_modelaccessor
- reload(mock_modelaccessor) # in case nose2 loaded it in a previous test
+ reload(mock_modelaccessor) # in case nose2 loaded it in a previous test
reload(xossynchronizer.modelaccessor) # in case nose2 loaded it in a previous test
from xossynchronizer.modelaccessor import model_accessor
from model_policy_att_workflow_driver_serviceinstance import AttWorkflowDriverServiceInstancePolicy, AttHelpers
self.AttHelpers = AttHelpers
- from mock_modelaccessor import MockObjectList
-
# import all class names to globals
for (k, v) in model_accessor.all_model_classes.items():
globals()[k] = v
- # Some of the functions we call have side-effects. For example, creating a VSGServiceInstance may lead to creation of
- # tags. Ideally, this wouldn't happen, but it does. So make sure we reset the world.
+ # Some of the functions we call have side-effects. For example, creating a VSGServiceInstance may lead to
+ # creation of tags. Ideally, this wouldn't happen, but it does. So make sure we reset the world.
model_accessor.reset_all_object_stores()
-
self.policy = AttWorkflowDriverServiceInstancePolicy(model_accessor=model_accessor)
self.si = AttWorkflowDriverServiceInstance()
self.si.owner = AttWorkflowDriverService()
@@ -72,7 +70,7 @@
admin_state="ENABLED"
)
with patch.object(ONUDevice.objects, "get_items") as get_onu, \
- patch.object(onu, "save") as onu_save:
+ patch.object(onu, "save") as onu_save:
get_onu.return_value = [onu]
self.policy.update_onu("brcm1234", "ENABLED")
@@ -80,13 +78,13 @@
self.policy.update_onu("brcm1234", "DISABLED")
self.assertEqual(onu.admin_state, "DISABLED")
- onu_save.assert_called_with(always_update_timestamp=True, update_fields=['admin_state', 'serial_number', 'updated'])
-
+ onu_save.assert_called_with(
+ always_update_timestamp=True, update_fields=[
+ 'admin_state', 'serial_number', 'updated'])
def test_enable_onu(self):
with patch.object(self.AttHelpers, "validate_onu") as validate_onu, \
- patch.object(self.policy, "update_onu") as update_onu, \
- patch.object(self.si, "save") as save_si:
+ patch.object(self.policy, "update_onu") as update_onu:
validate_onu.return_value = [True, "valid onu"]
self.policy.process_onu_state(self.si)
@@ -98,8 +96,7 @@
def test_disable_onu(self):
with patch.object(self.AttHelpers, "validate_onu") as validate_onu, \
- patch.object(self.policy, "update_onu") as update_onu, \
- patch.object(self.si, "save") as save_si:
+ patch.object(self.policy, "update_onu") as update_onu:
validate_onu.return_value = [False, "invalid onu"]
self.policy.process_onu_state(self.si)
@@ -115,8 +112,8 @@
when necessary
"""
with patch.object(self.policy, "process_onu_state") as process_onu_state, \
- patch.object(self.policy, "update_onu") as update_onu, \
- patch.object(self.policy, "get_subscriber") as get_subscriber:
+ patch.object(self.policy, "update_onu") as update_onu, \
+ patch.object(self.policy, "get_subscriber") as get_subscriber:
update_onu.return_value = None
get_subscriber.return_value = None
@@ -132,7 +129,6 @@
self.policy.handle_update(self.si)
process_onu_state.assert_called_with(self.si)
-
def test_get_subscriber(self):
sub = RCORDSubscriber(
@@ -243,8 +239,8 @@
self.si.mac_address = "4321"
with patch.object(sub, "save") as sub_save, \
- patch.object(RCORDIpAddress.objects, "get_items") as get_ips, \
- patch.object(ip, "save_changed_fields") as ip_mock:
+ patch.object(RCORDIpAddress.objects, "get_items") as get_ips, \
+ patch.object(ip, "save_changed_fields") as ip_mock:
get_ips.return_value = [ip]
ip_mock.return_value = []
@@ -267,7 +263,7 @@
self.si.mac_address = "4321"
with patch.object(sub, "save") as sub_save, \
- patch.object(RCORDIpAddress, "save", autospec=True) as ip_mock:
+ patch.object(RCORDIpAddress, "save", autospec=True) as ip_mock:
ip_mock.return_value = []
@@ -288,12 +284,12 @@
)
with patch.object(self.policy, "get_subscriber") as get_subscriber, \
- patch.object(self.policy, "update_onu") as update_onu, \
- patch.object(self.policy, "update_subscriber") as update_subscriber:
+ patch.object(self.policy, "update_onu") as update_onu, \
+ patch.object(self.policy, "update_subscriber") as update_subscriber:
get_subscriber.return_value = None
self.policy.handle_update(self.si)
- update_onu.assert_called_with(sub.onu_device, "DISABLED");
+ update_onu.assert_called_with(sub.onu_device, "DISABLED")
self.assertEqual(update_subscriber.call_count, 0)
get_subscriber.return_value = sub
@@ -303,4 +299,3 @@
if __name__ == '__main__':
unittest.main()
-
diff --git a/xos/synchronizer/model_policies/test_model_policy_att_workflow_driver_whitelistentry.py b/xos/synchronizer/model_policies/test_model_policy_att_workflow_driver_whitelistentry.py
index 9477258..7bc24b4 100644
--- a/xos/synchronizer/model_policies/test_model_policy_att_workflow_driver_whitelistentry.py
+++ b/xos/synchronizer/model_policies/test_model_policy_att_workflow_driver_whitelistentry.py
@@ -15,11 +15,13 @@
import unittest
-from mock import patch, call, Mock, PropertyMock
+from mock import patch
-import os, sys
+import os
+import sys
-test_path=os.path.abspath(os.path.dirname(os.path.realpath(__file__)))
+test_path = os.path.abspath(os.path.dirname(os.path.realpath(__file__)))
+
class TestModelPolicyAttWorkflowDriverWhiteListEntry(unittest.TestCase):
def setUp(self):
@@ -37,7 +39,7 @@
import xossynchronizer.modelaccessor
import mock_modelaccessor
- reload(mock_modelaccessor) # in case nose2 loaded it in a previous test
+ reload(mock_modelaccessor) # in case nose2 loaded it in a previous test
reload(xossynchronizer.modelaccessor) # in case nose2 loaded it in a previous test
from xossynchronizer.modelaccessor import model_accessor
@@ -51,15 +53,14 @@
for (k, v) in model_accessor.all_model_classes.items():
globals()[k] = v
- # Some of the functions we call have side-effects. For example, creating a VSGServiceInstance may lead to creation of
- # tags. Ideally, this wouldn't happen, but it does. So make sure we reset the world.
+ # Some of the functions we call have side-effects. For example, creating a VSGServiceInstance may lead to
+ # creation of tags. Ideally, this wouldn't happen, but it does. So make sure we reset the world.
model_accessor.reset_all_object_stores()
self.policy = AttWorkflowDriverWhiteListEntryPolicy(model_accessor=model_accessor)
self.service = AttWorkflowDriverService()
-
def tearDown(self):
sys.path = self.sys_path_save
self.service = None
@@ -67,39 +68,44 @@
def test_enable_onu(self):
si = AttWorkflowDriverServiceInstance(serial_number="BRCM333", owner_id=self.service.id, valid="invalid")
with patch.object(self.AttHelpers, "validate_onu") as validate_onu, \
- patch.object(si, "save") as save_si:
+ patch.object(si, "save") as save_si:
validate_onu.return_value = [True, "valid onu"]
self.policy.validate_onu_state(si)
save_si.assert_called_once()
- save_si.assert_called_with(always_update_timestamp=True, update_fields=['onu_state', 'serial_number', 'updated'])
+ save_si.assert_called_with(
+ always_update_timestamp=True, update_fields=[
+ 'onu_state', 'serial_number', 'updated'])
def test_disable_onu(self):
si = AttWorkflowDriverServiceInstance(serial_number="BRCM333", owner_id=self.service.id, valid="invalid")
with patch.object(self.AttHelpers, "validate_onu") as validate_onu, \
- patch.object(si, "save") as save_si:
+ patch.object(si, "save") as save_si:
validate_onu.return_value = [False, "invalid onu"]
self.policy.validate_onu_state(si)
save_si.assert_called_once()
- save_si.assert_called_with(always_update_timestamp=True, update_fields=['onu_state', 'serial_number', 'updated'])
+ save_si.assert_called_with(
+ always_update_timestamp=True, update_fields=[
+ 'onu_state', 'serial_number', 'updated'])
def test_whitelist_update(self):
si = AttWorkflowDriverServiceInstance(serial_number="BRCM333", owner_id=self.service.id)
wle = AttWorkflowDriverWhiteListEntry(serial_number="brcm333", owner_id=self.service.id, owner=self.service)
with patch.object(AttWorkflowDriverServiceInstance.objects, "get_items") as oss_si_items, \
- patch.object(self.policy, "validate_onu_state") as validate_onu_state, \
- patch.object(wle, "save") as wle_save:
+ patch.object(self.policy, "validate_onu_state") as validate_onu_state, \
+ patch.object(wle, "save") as wle_save:
oss_si_items.return_value = [si]
-
self.policy.handle_update(wle)
validate_onu_state.assert_called_with(si)
self.assertTrue(wle.backend_need_delete_policy)
- wle_save.assert_called_with(always_update_timestamp=False, update_fields=['backend_need_delete_policy', 'owner', 'serial_number'])
+ wle_save.assert_called_with(
+ always_update_timestamp=False, update_fields=[
+ 'backend_need_delete_policy', 'owner', 'serial_number'])
def test_whitelist_delete(self):
si = AttWorkflowDriverServiceInstance(serial_number="BRCM333", owner_id=self.service.id)
@@ -113,7 +119,10 @@
validate_onu_state.assert_called_with(si)
self.assertTrue(wle.backend_need_reap)
- wle_save.assert_called_with(always_update_timestamp=False, update_fields=['backend_need_reap', 'owner', 'serial_number'])
+ wle_save.assert_called_with(
+ always_update_timestamp=False, update_fields=[
+ 'backend_need_reap', 'owner', 'serial_number'])
+
+
if __name__ == '__main__':
unittest.main()
-