[VOL-3285] Resolving statis code analysis warnings
Change-Id: Iaddaae92c649fd27ce0a63f1786af594667c9e8e
diff --git a/cmd/bbsim/bbsim.go b/cmd/bbsim/bbsim.go
index 665ebd7..e7618f9 100644
--- a/cmd/bbsim/bbsim.go
+++ b/cmd/bbsim/bbsim.go
@@ -51,11 +51,11 @@
reflection.Register(grpcServer)
- go grpcServer.Serve(lis)
+ go func() { _ = grpcServer.Serve(lis) }()
go startApiRestServer(apiDoneChannel, group, address)
- select {
- case <-apiDoneChannel:
+ x := <-apiDoneChannel
+ if x {
// if the API channel is closed, stop the gRPC server
grpcServer.Stop()
log.Warnf("Stopping API gRPC server")
@@ -90,10 +90,10 @@
}
}()
- select {
- case <-apiDoneChannel:
+ x := <-apiDoneChannel
+ if x {
log.Warnf("Stopping API REST server")
- s.Shutdown(ctx)
+ _ = s.Shutdown(ctx)
}
group.Done()
@@ -113,17 +113,15 @@
apiserver := grpc.NewServer()
legacy.RegisterBBSimServiceServer(apiserver, api.BBSimLegacyServer{})
- go apiserver.Serve(listener)
+ go func() { _ = apiserver.Serve(listener) }()
// Start rest gateway for BBSim server
go api.StartRestGatewayService(apiDoneChannel, group, grpcAddress, restAddress)
- select {
- case <-apiDoneChannel:
+ x := <-apiDoneChannel
+ if x {
// if the API channel is closed, stop the gRPC server
log.Warnf("Stopping legacy API gRPC server")
apiserver.Stop()
- break
-
}
group.Done()
@@ -143,7 +141,7 @@
if err != nil {
log.Fatal(err)
}
- pprof.StartCPUProfile(f)
+ _ = pprof.StartCPUProfile(f)
}
log.WithFields(log.Fields{
@@ -194,7 +192,7 @@
go startApiServer(apiDoneChannel, &wg)
go startLegacyApiServer(apiDoneChannel, &wg)
log.Debugf("Started APIService")
- if common.Options.BBSim.SadisServer != false {
+ if common.Options.BBSim.SadisServer {
wg.Add(1)
go sadis.StartRestServer(olt, &wg)
}