[VOL-3285] Resolving statis code analysis warnings
Change-Id: Iaddaae92c649fd27ce0a63f1786af594667c9e8e
diff --git a/internal/bbsim/responders/dhcp/dhcp.go b/internal/bbsim/responders/dhcp/dhcp.go
index 1ce71d6..227ce8e 100644
--- a/internal/bbsim/responders/dhcp/dhcp.go
+++ b/internal/bbsim/responders/dhcp/dhcp.go
@@ -20,6 +20,10 @@
"context"
"errors"
"fmt"
+ "net"
+ "reflect"
+ "strconv"
+
"github.com/google/gopacket"
"github.com/google/gopacket/layers"
"github.com/looplab/fsm"
@@ -28,9 +32,6 @@
omci "github.com/opencord/omci-sim"
"github.com/opencord/voltha-protos/v2/go/openolt"
log "github.com/sirupsen/logrus"
- "net"
- "reflect"
- "strconv"
)
var GetGemPortId = omci.GetGemPortId
@@ -100,7 +101,7 @@
func createDHCPDisc(oltId int, intfId uint32, onuId uint32, macAddress net.HardwareAddr) *layers.DHCPv4 {
dhcpLayer := createDefaultDHCPReq(oltId, intfId, onuId, macAddress)
defaultOpts := createDefaultOpts(intfId, onuId)
- dhcpLayer.Options = append([]layers.DHCPOption{layers.DHCPOption{
+ dhcpLayer.Options = append([]layers.DHCPOption{{
Type: layers.DHCPOptMessageType,
Data: []byte{byte(layers.DHCPMsgTypeDiscover)},
Length: 1,
@@ -179,7 +180,7 @@
DstPort: 67,
}
- udpLayer.SetNetworkLayerForChecksum(ipLayer)
+ _ = udpLayer.SetNetworkLayerForChecksum(ipLayer)
if err := gopacket.SerializeLayers(buffer, options, ethernetLayer, ipLayer, udpLayer, dhcp); err != nil {
dhcpLogger.Error("SerializeLayers")
return nil, err
@@ -253,10 +254,10 @@
}
log.WithFields(log.Fields{
- "OnuId": msg.OnuId,
- "IntfId": msg.IntfId,
+ "OnuId": msg.OnuId,
+ "IntfId": msg.IntfId,
"GemPort": gemid,
- "Type": "DHCP",
+ "Type": "DHCP",
}).Trace("sending-pkt")
data := &openolt.Indication_PktInd{PktInd: &openolt.PacketIndication{
@@ -493,7 +494,7 @@
srcMac, _ := packetHandlers.GetSrcMacAddressFromPacket(pkt)
dstMac, _ := packetHandlers.GetDstMacAddressFromPacket(pkt)
- if isIncoming == true {
+ if isIncoming {
onuPacket := openolt.OnuPacket{
IntfId: ponPortId,