[VOL-4382] Adding 'AlarmIndication' to MessageType String converter, adding support for ICMP packets in order to avoid false error messages
Change-Id: If48948b0a96a7c87fe62191f880bb5617885d542
diff --git a/internal/bbsim/devices/nni.go b/internal/bbsim/devices/nni.go
index 2159f6d..d4dfd23 100644
--- a/internal/bbsim/devices/nni.go
+++ b/internal/bbsim/devices/nni.go
@@ -55,8 +55,9 @@
func (n *NniPort) handleNniPacket(packet gopacket.Packet) error {
isDhcp := packetHandlers.IsDhcpPacket(packet)
isLldp := packetHandlers.IsLldpPacket(packet)
+ isIcmp := packetHandlers.IsIcmpPacket(packet)
- if !isDhcp && !isLldp {
+ if !isDhcp && !isLldp && !isIcmp {
nniLogger.WithFields(log.Fields{
"packet": packet,
}).Trace("Dropping NNI packet as it's not DHCP")
@@ -91,6 +92,8 @@
} else if isLldp {
// TODO rework this when BBSim supports data-plane packets
nniLogger.Trace("Received LLDP Packet, ignoring it")
+ } else if isIcmp {
+ nniLogger.Trace("Received ICMP Packet, ignoring it")
}
return nil
}