[VOL-5100] - periodic-voltha-test-bbsim

jjb/pipeline/voltha/master/bbsim-tests.groovy
---------------------------------------------
  o Disable installKind() call for now.  Jenkins shared library
    repository checkout is two changesets behind branch=master (?)

jjb/shell/helm-lint.sh
----------------------
   o Added a call to (lint) helmrepo.sh, an extra script jenkins will launch.
   o Correct variant behavior, interactive lint checking should expose the
     the same problems that jenkins will eventually fail a job for.

Change-Id: I654f04ea1d530bd9354177ed168cf2742b5e7257
diff --git a/jjb/pipeline/voltha/master/bbsim-tests.groovy b/jjb/pipeline/voltha/master/bbsim-tests.groovy
index fc4b661..a2f7605 100644
--- a/jjb/pipeline/voltha/master/bbsim-tests.groovy
+++ b/jjb/pipeline/voltha/master/bbsim-tests.groovy
@@ -61,6 +61,16 @@
 // -----------------------------------------------------------------------
 // Intent: Phase helper method
 // -----------------------------------------------------------------------
+// NOTE: installKind temporarily disabled:
+//   o error makes little sense, install.Kind.{groovy,sh} exist in vars/
+//   o jenkins shared library -- checked out on server disk is stale
+//     2 changesets behind current ?!?!
+//   o Disable call for now to revive the pipeline.
+// 10:26:05  org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
+// 10:26:05  WorkflowScript: 73: unexpected token: installKind @ line 73, column 2.
+// 10:26:05     installKind(name)
+// 10:26:05      ^
+// -----------------------------------------------------------------------
 Boolean install_kind(String name)
 {
     String iam = getIam('installKind')
@@ -70,7 +80,7 @@
     try
     {
 	println("** ${iam} Running: installKind() { debug:true }"
-	installKind(name)
+	// installKind(name)
 	println("** ${iam}: Ran to completion")
 	ans = True // iff
     }
diff --git a/jjb/shell/helm-lint.sh b/jjb/shell/helm-lint.sh
index e2f9e23..9407c04 100644
--- a/jjb/shell/helm-lint.sh
+++ b/jjb/shell/helm-lint.sh
@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-# SPDX-FileCopyrightText: 2020-2022 Open Networking Foundation <info@opennetworking.org>
+# Copyright 2020-2023 Open Networking Foundation (ONF) and the ONF Contributors
 # SPDX-License-Identifier: Apache-2.0
 
 set -eu -o pipefail
@@ -8,17 +8,25 @@
 export OLD_REPO_DIR="cord-charts-repo"
 
 # Setup helm and external repos
+cat <<EOM
+
+** -----------------------------------------------------------------------
+** Configure helm and external repos
+** -----------------------------------------------------------------------
+EOM
+
 helm repo add stable https://charts.helm.sh/stable
 helm repo add rook-release https://charts.rook.io/release
 helm repo add cord https://charts.opencord.org
 
+## Clone tool chain
 git clone ssh://jenkins@gerrit.opencord.org:29418/helm-repo-tools.git
 ./helm-repo-tools/helmlint.sh clean
 echo "*.lock" >> .gitignore
 
 # Specify the remote branch to compare against
 export COMPARISON_BRANCH="origin/$GERRIT_BRANCH"
-./helm-repo-tools/chart_version_check.sh
+./helm-repo-tools/chart_version_check.sh  # [TODO] make lint-chart
 
 # Configure git
 git config --global user.email "do-not-reply@opennetworking.org"
@@ -26,4 +34,7 @@
 
 # Check for chart version conflicts by building the repo (don't upload)
 git clone "ssh://jenkins@gerrit.opencord.org:29418/$OLD_REPO_DIR.git"
-./helm-repo-tools/helmrepo.sh
+
+./helm-repo-tools/helmrepo.sh   # [TODO] make ???
+
+# [EOF]