[VOL-5100] - periodic-voltha-test-bbsim

vars/installKind.groovy
vars/installKind.sh
-----------------------
  o Convert installKind.groovy from a closure based method to function with parameters.
  o Script failure mode is completely silent so trying something different.
  o Extract inlined download script and place in named script installKind.sh
    jenkins issued a strange error about quoting shell variable $* to display args.
  o With groovy and shell separated lint can now syntax check both sources.

Change-Id: I68ca3f968a41a479535a8f9b96f0275a0919d4bd
diff --git a/jjb/pipeline/voltha/master/bbsim-tests.groovy b/jjb/pipeline/voltha/master/bbsim-tests.groovy
index 6fecb98..47e6c10 100644
--- a/jjb/pipeline/voltha/master/bbsim-tests.groovy
+++ b/jjb/pipeline/voltha/master/bbsim-tests.groovy
@@ -70,7 +70,7 @@
     try
     {
 	println("** ${iam} Running: installKind() { debug:true }"
-	installKind() { debug:true }
+	installKind(branch_name)
 	println("** ${iam}: Ran to completion")
 	ans = True // iff
     }