commit 90aacabd55b4e0e106fe0f2a61ee75a759755a24
author Matteo Scandolo <teo@opennetworking.org> Thu Nov 19 18:20:49 2020 +0000
committer Matteo Scandolo <teo@opennetworking.org> Thu Nov 19 18:20:49 2020 +0000
tree f38824cf4730ba098384f34b17eec25a1d9c7f85
parent 1b07e0896a40452b6772615f2f73b88095d494b9

Revert "Actually parsing out images only when different from master and avoid setting helm flags if not needed"

This reverts commit 1b07e0896a40452b6772615f2f73b88095d494b9.

Reason for revert: Found the issue that this patch was resolving and taking a different approach

Change-Id: I7f801e38b34b31128d149d8890e7e0e7055aba81

jjb/pipeline/voltha-scale-test.groovy

diff --git a/jjb/pipeline/voltha-scale-test.groovy b/jjb/pipeline/voltha-scale-test.groovy
index 2e92794..ed7e764 100644
--- a/jjb/pipeline/voltha-scale-test.groovy
+++ b/jjb/pipeline/voltha-scale-test.groovy
@@ -223,7 +223,7 @@
             fi
 
             # BBSim custom image handling
-            if [ "${bbsimImg.trim()}" != '' ] && [ "${bbsimImg.trim()}" != 'voltha/bbsim:master' ] && [ "$GERRIT_PROJECT" != 'bbsim' ]; then
+            if [ '${bbsimImg.trim()}' != '' ] && [ '\$GERRIT_PROJECT' != 'bbsim' ]; then
               IFS=: read -r bbsimRepo bbsimTag <<< '${bbsimImg.trim()}'
               EXTRA_HELM_FLAGS+="--set images.bbsim.repository=\$bbsimRepo,images.bbsim.tag=\$bbsimTag "
             fi
@@ -231,32 +231,32 @@
             # VOLTHA and ofAgent custom image handling
             # NOTE to override the rw-core image in a released version you must set the ofAgent image too
             # TODO split ofAgent and voltha-go
-            if [ "${rwCoreImg.trim()}" != '' ] && [ "${ofAgentImg.trim()}" != '' ] && [ "$GERRIT_PROJECT" != 'voltha-go' ]; then
+            if [ '${rwCoreImg.trim()}' != '' ] && [ '${ofAgentImg.trim()}' != '' ] && [ '\$GERRIT_PROJECT' != 'voltha-go' ]; then
               IFS=: read -r rwCoreRepo rwCoreTag <<< '${rwCoreImg.trim()}'
               IFS=: read -r ofAgentRepo ofAgentTag <<< '${ofAgentImg.trim()}'
               EXTRA_HELM_FLAGS+="--set images.rw_core.repository=\$rwCoreRepo,images.rw_core.tag=\$rwCoreTag,images.ofagent.repository=\$ofAgentRepo,images.ofagent.tag=\$ofAgentTag "
             fi
 
             # OpenOLT custom image handling
-            if [ "${openoltAdapterImg.trim()}" != '' ] && [ "${openoltAdapterImg.trim()}" != 'voltha/voltha-openolt-adapter:master' ] && [ "$GERRIT_PROJECT" != 'voltha-openolt-adapter' ]; then
+            if [ '${openoltAdapterImg.trim()}' != '' ] && [ '\$GERRIT_PROJECT' != 'voltha-openolt-adapter' ]; then
               IFS=: read -r openoltAdapterRepo openoltAdapterTag <<< '${openoltAdapterImg.trim()}'
               EXTRA_HELM_FLAGS+="--set images.adapter_open_olt.repository=\$openoltAdapterRepo,images.adapter_open_olt.tag=\$openoltAdapterTag "
             fi
 
             # OpenONU custom image handling
-            if [ "${openonuAdapterImg.trim()}" != '' ] && [ "${openonuAdapterImg.trim()}" != 'voltha/voltha-openonu-adapter:master' ] && [ "$GERRIT_PROJECT" != 'voltha-openonu-adapter' ]; then
+            if [ '${openonuAdapterImg.trim()}' != '' ] && [ '\$GERRIT_PROJECT' != 'voltha-openonu-adapter' ]; then
               IFS=: read -r openonuAdapterRepo openonuAdapterTag <<< '${openonuAdapterImg.trim()}'
               EXTRA_HELM_FLAGS+="--set images.adapter_open_onu.repository=\$openonuAdapterRepo,images.adapter_open_onu.tag=\$openonuAdapterTag "
             fi
 
             # OpenONU GO custom image handling
-            if [ "${openonuAdapterGoImg.trim()}" != '' ] && [ "${openonuAdapterGoImg.trim()}" != 'voltha/voltha-openonu-adapter-go:master' ] && [ "$GERRIT_PROJECT" != 'voltha-openonu-adapter-go' ]; then
+            if [ '${openonuAdapterGoImg.trim()}' != '' ] && [ '\$GERRIT_PROJECT' != 'voltha-openonu-adapter-go' ]; then
               IFS=: read -r openonuAdapterGoRepo openonuAdapterGoTag <<< '${openonuAdapterGoImg.trim()}'
               EXTRA_HELM_FLAGS+="--set use_openonu_adapter_go=true,images.adapter_open_onu_go.repository=\$openonuAdapterGoRepo,images.adapter_open_onu.tag=\$openonuAdapterGoTag "
             fi
 
             # ONOS custom image handling
-            if [ "${onosImg.trim()}" != '' ] && [ "${onosImg.trim()}" != 'voltha/voltha-onos:master' ] && [ "$GERRIT_PROJECT" != 'voltha-onos' ]; then
+            if [ '${onosImg.trim()}' != '' ] && [ '\$GERRIT_PROJECT' != 'voltha-onos' ]; then
               IFS=: read -r onosRepo onosTag <<< '${onosImg.trim()}'
               EXTRA_HELM_FLAGS+="--set images.onos.repository=\$onosRepo,images.onos.tag=\$onosTag "
             fi
@@ -292,10 +292,6 @@
               EXTRA_HELM_FLAGS+="--set images.adapter_open_onu.repository=${dockerRegistry}/voltha/voltha-openonu-adapter,images.adapter_open_onu.tag=voltha-scale "
             fi
 
-            if [ '\$GERRIT_PROJECT' == 'voltha-openonu-adapter-go' ]; then
-              EXTRA_HELM_FLAGS+="--set images.adapter_open_onu_go.repository=${dockerRegistry}/voltha/voltha-openonu-adapter-go,images.adapter_open_onu_go.tag=voltha-scale "
-            fi
-
             if [ '\$GERRIT_PROJECT' == 'ofagent-go' ]; then
               EXTRA_HELM_FLAGS+="--set images.ofagent.repository=${dockerRegistry}/voltha/voltha-ofagent-go,images.ofagent.tag=voltha-scale "
             fi