VOL-4795 - Researching community pod faiure.
vars/getVolthaCode.groovy
-------------------------
o Re-add conditional to skip checkout when cfg.gerritProject is empty
that was lost during the try/catch block addition.
o Added a note to revisit the logic, a value != null should be used
as a skip conditional to detect problems when config hash is
undefined due to an error.
Change-Id: I6f1655464003101538b3e05e4eef78ceb3c52781
diff --git a/vars/getVolthaCode.groovy b/vars/getVolthaCode.groovy
index b8083a2..74fa88f 100644
--- a/vars/getVolthaCode.groovy
+++ b/vars/getVolthaCode.groovy
@@ -37,7 +37,17 @@
// We are always downloading those repos, if the patch under test is in one of those
// just checkout the patch, no need to clone it again
- if ( !(cfg.gerritProject in frequent_repos))
+ if (cfg.gerritProject == '')
+ {
+ // Revisit:
+ // gerritProject should be defined. Ignore when empty was likely
+ // added to support manually re-running a job when repo values
+ // may not be defined.
+ // Unfortunately the conditional can also inadvertently bypass
+ // checkout during an error condition.
+ // Case: when cfg= is invalid due to a jenkins hiccup.
+ }
+ elseif (!(cfg.gerritProject in frequent_repos))
{
repo_project = "https://gerrit.opencord.org/${cfg.gerritProject}"