commit ca557dcba34de90e9236946497e81fdc1a622632
author Joey Armstrong <joey@opennetworking.org> Mon Apr 03 17:12:32 2023 -0400
committer Joey Armstrong <joey@opennetworking.org> Mon Apr 03 17:15:30 2023 -0400
tree 7206e9a87e979ba5f6fc84b63abf300e55ee88a6
parent da159d3f451d8fdcfe06434de43ed575d1db5f8b

Remove path from popd, no argument should be passed

Change-Id: I325b8aaa51c3aa28859705012af437ce65ea49ba

jjb/shell/github-release.sh

diff --git a/jjb/shell/github-release.sh b/jjb/shell/github-release.sh
index ee95292..22cff84 100755
--- a/jjb/shell/github-release.sh
+++ b/jjb/shell/github-release.sh
@@ -276,10 +276,10 @@
         get_version __ver
 
     elif [[ -v WORKSPACE ]] && [[ -v GITHUB_TOKEN ]]; then # i_am_jenkins
-	declare -p GERRIT_PROJECT
-	pushd "$GERRIT_PROJECT" || error "pushd GERRIT_PROJECT= failed"
+	local path="$GERRIT_PROJECT"
+	pushd "$path" || error "pushd GERRIT_PROJECT= failed $(declare -p path)"
         __ver="$(git tag -l --points-at HEAD)"
-	popd "$GERRIT_PROJECT" || error "popd GERRIT_PROJECT= failed"
+	popd || error "popd GERRIT_PROJECT= failed"
 
     elif [[ -v argv_version_file ]]; then # local debug
         [[ ! -f VERSION ]] && error "./VERSION file not found"
@@ -287,10 +287,10 @@
         __ver="v${tmp[0]}"
 
     else
-	declare -p GERRIT_PROJECT
-	pushd "$GERRIT_PROJECT" || error "pushd GERRIT_PROJECT= failed"
+	local path="$GERRIT_PROJECT"
+	pushd "$path" || error "pushd GERRIT_PROJECT= failed $(declare -p path)"
         __ver="$(git tag -l --points-at HEAD)"
-	popd "$GERRIT_PROJECT" || error "popd GERRIT_PROJECT= failed"
+	popd || error "popd GERRIT_PROJECT= failed"
     fi
 
     # ------------------------------------------------------