[VOL-5296] shellcheck and yamllint cleanups

jjb/shell/github-release.sh
---------------------------
  o Cleanup shellcheck warnings prior to working on voltctl error.

jjb/docker-publish.yaml
-----------------------
   o repo: ci-management requires a yaml config edit in order for a job
     to run so arbitrarily modify docker-publish.yaml.
   o Cleanup yamllint warnings about long lines.

[HOWTO: test]
  % make lint-shell
    shellcheck jjb/shell/github-release.sh
  % make lint-yaml-all
    yamllint --strict jjb/docker-publish.yaml

Change-Id: If367e80da7c2e12c2025769eca716e439d6396ee
diff --git a/jjb/docker-publish.yaml b/jjb/docker-publish.yaml
index 4706c45..ad09132 100644
--- a/jjb/docker-publish.yaml
+++ b/jjb/docker-publish.yaml
@@ -1,11 +1,32 @@
 ---
-# generic docker image building + dockerhub publishing tasks
+
+# -----------------------------------------------------------------------
+# Copyright 2019-2024 Open Networking Foundation Contributors
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http:#www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# -----------------------------------------------------------------------
+# SPDX-FileCopyrightText: 2019-2024 Open Networking Foundation Contributors
+# SPDX-License-Identifier: Apache-2.0
+# -----------------------------------------------------------------------
+# Intent: Generic docker image building + dockerhub publishing tasks
+# -----------------------------------------------------------------------
 
 - job-template:
     id: docker-publish
     name: 'docker-publish_{project}'
-    description: |
-      Created by {id} job-template from ci-management/jjb/docker-publish.yaml, script pipeline/docker-publish.groovy
+    description: >+
+      Created by {id} job-template from ci-management/jjb/docker-publish.yaml,
+      script pipeline/docker-publish.groovy
 
     triggers:
       - cord-infra-gerrit-trigger-merge:
@@ -54,18 +75,22 @@
       - string:
           name: dockerRepo
           default: '{docker-repo}'
-          description: "Docker repository to push to ('opencord', 'xosproject', etc.)"
+          description: >
+            "Docker repository to push to ('opencord', 'xosproject', etc.)"
 
       - string:
           name: dockerRegistry
           default: '{docker-registry}'
           description: "Docker registry to push to (blank for DockerHub)"
 
-      # AWS CPU arch names: `x86_64` `arm64` (which don't align to vendor names... *sigh*)
+      # AWS CPU arch names: `x86_64` `arm64`
+      # (which don't align to vendor names... *sigh*)
       - string:
           name: dockerArchList
           default: 'x86_64'
-          description: "List of architectures to build containers on, pipe separated (nonfunctional currently)"
+          description: >
+            "List of architectures to build containers on, pipe separated
+            (nonfunctional currently)"
 
       - string:
           name: maintainers