commit 34a164d1f6b6ceb22825302daf281ea890cc5419
author Zack Williams <zdw@opennetworking.org> Tue Apr 03 17:02:10 2018 -0700
committer Zack Williams <zdw@opennetworking.org> Wed Apr 04 16:52:42 2018 +0000
tree e4a4aaa238f36d618a552dcbe408c0575261eca0
parent 21d5c2011a38c5be5636c2ff1335cceee46ea397

[CORD-2809]
Imagebuilder compat fixes with docker 3.x pip modules

Change-Id: I6950ca7156c8e649593124f3753fcf722b8a6ed6

scripts/imagebuilder.py

diff --git a/scripts/imagebuilder.py b/scripts/imagebuilder.py
index 27ff8d2..e13ae8f 100755
--- a/scripts/imagebuilder.py
+++ b/scripts/imagebuilder.py
@@ -39,6 +39,8 @@
 global buildable_images
 global pull_only_images
 
+DOCKER_PY_VERSION = 0
+
 
 def setup_logging(name=None, logfile=False):
     global args
@@ -108,6 +110,9 @@
     parser.add_argument('-v', '--verbosity', action='count', default=1,
                         help="Repeat to increase log level")
 
+    parser.add_argument('-x', '--force', action="store_true",
+                        help="Force removal of tags (may delete images)")
+
     args = parser.parse_args()
 
     if args.verbosity > 1:
@@ -175,7 +180,7 @@
                                    filter_list['docker_image_whitelist']),
                                    pull_only_images)
 
-        except:
+        except KeyError:
             LOG.exception("Problem with filter list file")
             sys.exit(1)
 
@@ -935,7 +940,7 @@
 
                                 # remove build_tag from image
                                 name_bt = "%s:%s" % (base_name, build_tag)
-                                self.dc.remove_image(name_bt, False, True)
+                                self.dc.remove_image(name_bt, args.force, True)
 
                             else:
                                 LOG.info(" Image %s has obsolete labels, lacks"
@@ -1318,17 +1323,23 @@
             try:
                 LOG.info("Building image: %s" % image)
 
-                for stat_d in self.dc.build(tag=image_build_tag,
-                                            buildargs=buildargs,
-                                            nocache=args.build,
-                                            custom_context=True,
-                                            fileobj=context_tar,
-                                            dockerfile=dockerfile,
-                                            rm=True,
-                                            forcerm=True,
-                                            pull=False,
-                                            stream=True,
-                                            decode=True):
+                buildparams = dict(
+                    tag=image_build_tag,
+                    buildargs=buildargs,
+                    nocache=args.build,
+                    custom_context=True,
+                    fileobj=context_tar,
+                    dockerfile=dockerfile,
+                    rm=True,
+                    forcerm=True,
+                    pull=False,
+                    decode=True
+                )
+
+                if DOCKER_PY_VERSION == 2:
+                    buildparams['stream'] = True
+
+                for stat_d in self.dc.build(**buildparams):
 
                     if 'stream' in stat_d:
 
@@ -1411,6 +1422,10 @@
                           "remove docker-py 1.x, install docker 2.x")
                 sys.exit(1)
 
+            DOCKER_PY_VERSION = 2
+            if LooseVersion(docker_version) >= LooseVersion('3.0.0'):
+                DOCKER_PY_VERSION = 3
+
             import docker
             from docker import utils as DockerUtils
             from docker import errors as DockerErrors