The 5.0 and earlier releases of CORD were done on a patch branch, named cord-4.1
, cord-5.0
, etc., which received bug fixes as required.
Starting with 6.0, the decision was made that individual components of CORD would be released and versioned separately. The versioning method chosen was Semantic Versioning, with versions numbers incrementing with per the MAJOR.MINOR.PATCH method as changes are made.
For development versions, using either SemVer or the slightly different PEP440 syntax (.dev#
instead of -dev#
) if using Python code are the recommended formats.
To avoid confusion, all components that existed prior to 6.0 started their independent versioning at version 6.0.0
.
Formal CORD releases are the tags on two repositories, helm-charts and automation-tools. The helm charts refer to specific container versions used with CORD, which encapsulate individual components which are versioned independently. For example, a future 6.1.0 release might still include some components that are still using the original 6.0.0 version.
While not created by default during a release, patch branches may be created for tracking ongoing work, but this is left up to the owners/developers of the individual components.
Support and patches are provided for the currently released version and the last point revision of the previous release - for example, while developing 6.0, we continued to support both 5.0 and 4.1. Once 6.0 is released, support will be provided for 6.0 and 5.0, dropping 4.1
Update the VERSION
file to a released version (ex: 6.0.1
)
Make sure that any Docker parents are using a released version (FROM xosproject/xos-base:6.0.0
), or some other acceptably specific version (ex: FROM scratch
or FROM ubuntu-16.04
)
Create a patchset with these changes and submit it to Gerrit
If it passes tests, upon merge the commit will be tagged in git with the version string, and Docker images with the tag will be built and sent to Docker Hub.
To create a new version, the version string is updated in the language or framework specific method. For most of CORD, a file named VERSION
is created in the root of the git repository and contains a single line with the version string. Once a commit has been merged to a branch that changes the released version number, the version number is added as a git tag on the repo.
During development, the version is usually set to a development value, such as 6.0.0.dev1
. There can be multiple patchsets using the same non-release development version, and these versions don't create git tags on merge.
As it's confusing to have multiple git commits that contain the same released version string in the VERSION
file, Jenkins jobs have been put in place to prevent this from happening. The implementation is as follows:
When a patchset is submitted to Gerrit, the tag-collision-reject
Jenkins job runs. This checks that the version string in VERSION
is does not already exist as a git tag, and rejects any patchsets that have duplicate released versions. It ignores development and non-SemVer version strings.
This job also checks that if a released version number is used, any Dockerfile parent images are also using a fixed parent version, to better ensure repeatability of the image builds.
Once the patchset is approved and merged, the version-tag
Jenkins job runs. If the patchset uses a SemVer released version, additional checks are performed and if they pass a git tag is created on the git repo pointing to the commit.
Once the tag is created, if there are Docker images that need to be created from the commit, the publish-imagebuilder
job runs and creates tagged images corresponding to the git tags and branches and pushes them to Docker Hub.
Git history is public so it shouldn't be rewritten to abandon already merged commits, which means that there's not a way to un-release a version.
Reverting a commit leaves it in the git history, so if a broken version is released the correct action is to create a new fixed version, not try to fix the already released version.
If you've rebased your patchset onto a released version, the VERSION
file may be at a released version, which violates the "no two patchsets can contain the same released version". For example, an error like this:
Version string '1.0.1' found in 'VERSION' is a SemVer released version! ERROR: Duplicate tag: 1.0.1
Means that when you rebased your code, it found a 1.0.1
in the VERSION
file, which violates the "two commits can't have the same version" policy.
To fix this issue, you would change the contents of the VERSION
file to either increment to a dev version (ex: 1.0.2.dev1
) or a release version (ex: 1.0.2
) and resubmit your patchset.