commit 45b2a9d09563255bd53b5952dca7b3623e2e196c
author Harshmeet Singh <harshmeet.singh@bigswitch.com> Tue Jan 28 13:02:04 2014 -0600
committer Harshmeet Singh <harshmeet.singh@bigswitch.com> Tue Jan 28 13:02:04 2014 -0600
tree a66a42733f634ac509e830465948068eb86e9ca5
parent d209c0b4249c4cac5d0616a104384f225e90c938

addressed review comments

src/python/oftest/testutils.py

diff --git a/src/python/oftest/testutils.py b/src/python/oftest/testutils.py
index d6fa850..5b2e365 100644
--- a/src/python/oftest/testutils.py
+++ b/src/python/oftest/testutils.py
@@ -295,8 +295,7 @@
                       ip_id=1,  
                       icmp_type=8,
                       icmp_code=0,
-                      icmp_checksum=None,
-                      icmp_data="0"):
+                      icmp_data=''):
     """
     Return a simple ICMP packet
 
@@ -314,7 +313,6 @@
     @param ip_id IP Identification
     @param icmp_type ICMP type
     @param icmp_code ICMP code
-    @param icmp_checksum ICMP checksum    
     @param icmp_data ICMP data
 
     Generates a simple ICMP ECHO REQUEST.  Users
@@ -329,13 +327,11 @@
         pkt = scapy.Ether(dst=eth_dst, src=eth_src)/ \
             scapy.Dot1Q(prio=vlan_pcp, id=0, vlan=vlan_vid)/ \
             scapy.IP(src=ip_src, dst=ip_dst, ttl=ip_ttl, tos=ip_tos, id=ip_id)/ \
-            scapy.ICMP(type=icmp_type, code=icmp_code, chksum=icmp_checksum)/ \
-            icmp_data
+            scapy.ICMP(type=icmp_type, code=icmp_code)/ icmp_data
     else:
         pkt = scapy.Ether(dst=eth_dst, src=eth_src)/ \
             scapy.IP(src=ip_src, dst=ip_dst, ttl=ip_ttl, tos=ip_tos, id=ip_id)/ \
-            scapy.ICMP(type=icmp_type, code=icmp_code, chksum=icmp_checksum)/ \
-            icmp_data
+            scapy.ICMP(type=icmp_type, code=icmp_code)/ icmp_data
 
     pkt = pkt/("0" * (pktlen - len(pkt)))