tree 141dc2b90ba684cb149d42f7f36c1930059a9013
parent 49b323f18f7fe07d8743a5a81cd20474a508c2c1
author Rich Lane <rlane@bigswitch.com> 1381303261 -0700
committer Rich Lane <rlane@bigswitch.com> 1381303261 -0700

controller: serialize calls to socket.sendall

The sendall method is not atomic. Concurrent calls may end up with their data
interleaved on the socket. This is especially likely when the socket buffer
fills up, causing sendall to call select(2) between writes.

I noticed this bug when installing many flows. The echo reply sent by the
controller thread ended up in the middle of a flow mod.