Merge "[CORD-2848] Script to run `helm lint` on charts, fix pedantic lint errors that were found"
diff --git a/onos/values.yaml b/onos/values.yaml
index 06e133b..688fff6 100644
--- a/onos/values.yaml
+++ b/onos/values.yaml
@@ -25,6 +25,9 @@
tag: 1.12.0
pullPolicy: IfNotPresent
+nameOverride: ""
+fullnameOverride: ""
+
services:
serviceType: ClusterIP
ovsdb:
diff --git a/scripts/helmlint.sh b/scripts/helmlint.sh
new file mode 100755
index 0000000..5046257
--- /dev/null
+++ b/scripts/helmlint.sh
@@ -0,0 +1,46 @@
+#/usr/bin/env bash
+
+# Copyright 2018-present Open Networking Foundation
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# helmlint.sh
+# run `helm lint` on all helm charts that are found
+
+set +e
+echo "helmlint.sh, using helm version: $(helm version -c --short)"
+
+fail_lint=0
+
+for chart in $(find . -name Chart.yaml -print) ; do
+
+ chartdir=$(dirname "${chart}")
+
+ # lint with values.yaml if it exists
+ if [ -f "${chartdir}/values.yaml" ]; then
+ helm lint --strict --values "${chartdir}/values.yaml" "${chartdir}"
+ else
+ helm lint --strict "${chartdir}"
+ fi
+
+ rc=$?
+ if [[ $rc != 0 ]]; then
+ fail_lint=1
+ fi
+done
+
+if [[ $fail_lint != 0 ]]; then
+ exit 1
+fi
+
+exit 0
diff --git a/xos-profiles/rcord-lite/values.yaml b/xos-profiles/rcord-lite/values.yaml
index f104177..3a4974f 100644
--- a/xos-profiles/rcord-lite/values.yaml
+++ b/xos-profiles/rcord-lite/values.yaml
@@ -20,6 +20,9 @@
replicaCount: 1
+nameOverride: ""
+fullnameOverride: ""
+
pull_docker_registry:
image:
diff --git a/xos-services/addressmanager/values.yaml b/xos-services/addressmanager/values.yaml
index 56c263b..a61cebc 100644
--- a/xos-services/addressmanager/values.yaml
+++ b/xos-services/addressmanager/values.yaml
@@ -22,6 +22,9 @@
pull_docker_registry:
+nameOverride: ""
+fullnameOverride: ""
+
image:
repository: xosproject/addressmanager-synchronizer
tag: master
diff --git a/xos-services/exampleservice/values.yaml b/xos-services/exampleservice/values.yaml
index eecd157..6051b1c 100644
--- a/xos-services/exampleservice/values.yaml
+++ b/xos-services/exampleservice/values.yaml
@@ -22,6 +22,9 @@
pull_docker_registry:
+nameOverride: ""
+fullnameOverride: ""
+
image:
repository: xosproject/exampleservice-synchronizer
tag: master
diff --git a/xos-services/fabric/values.yaml b/xos-services/fabric/values.yaml
index 2ee4d70..78e8303 100644
--- a/xos-services/fabric/values.yaml
+++ b/xos-services/fabric/values.yaml
@@ -22,6 +22,9 @@
pull_docker_registry:
+nameOverride: ""
+fullnameOverride: ""
+
image:
repository: xosproject/fabric-synchronizer
tag: master
diff --git a/xos-services/onos-service/values.yaml b/xos-services/onos-service/values.yaml
index a713c38..28fc6d4 100644
--- a/xos-services/onos-service/values.yaml
+++ b/xos-services/onos-service/values.yaml
@@ -22,6 +22,9 @@
pull_docker_registry:
+nameOverride: ""
+fullnameOverride: ""
+
image:
repository: xosproject/onos-synchronizer
tag: master
diff --git a/xos-services/volt/values.yaml b/xos-services/volt/values.yaml
index 08bd4f6..a282c52 100644
--- a/xos-services/volt/values.yaml
+++ b/xos-services/volt/values.yaml
@@ -22,6 +22,9 @@
pull_docker_registry:
+nameOverride: ""
+fullnameOverride: ""
+
image:
repository: xosproject/volt-synchronizer
tag: master
diff --git a/xos-services/vsg-hw/values.yaml b/xos-services/vsg-hw/values.yaml
index 1d8f4e1..12b3f69 100644
--- a/xos-services/vsg-hw/values.yaml
+++ b/xos-services/vsg-hw/values.yaml
@@ -22,6 +22,9 @@
pull_docker_registry:
+nameOverride: ""
+fullnameOverride: ""
+
image:
repository: xosproject/vsg-hw-synchronizer
tag: master