Misc cleanups, shellcheck warnings.

helmrepo.sh
-----------
  o Use readarray -t to slurp command output.
  o Replace while read -r with for loop iteration over named vars.
  o Replace awk/string parsing with bash builtin string functions
    (added insulation against external shell command failures).
  o Added several functions to shorten all-code-in-main-program.
  o Added functions func_echo() and error() for formatted output.
  o Arguments --debug, --dry-run and --help added.
  o 'helm package' command functions added to support --dry-run use.
  o Detect and error on Chart.yaml files that lack 'version:'.
  o chart_yaml_diff - differentiate no_diff case from error induced.

Change-Id: I54d4f1e71291899540ec0f339ee9e033ca62a443
1 file changed