commit 37e8341a25020770afbf32a5b794cf27047691df
author Ilayda Ozdemir <ilayda.ozdemir@netsia.com> Sat Dec 19 14:54:27 2020 +0000
committer pierventre <pier@opennetworking.org> Mon Dec 21 12:41:16 2020 +0100
tree ab3f73dee73fc333decebce345b1e6b11b7c317a
parent c92fcf8a055042905f19f4b01c74f7ca7e7508cb

SEBA-1001 Fixed to problem of using multiple serialize methods

Change-Id: Ide906195f1ecf48e6fe570410beff64d1f8394e0

app/src/main/java/org/opencord/igmpproxy/impl/IgmpSender.java

diff --git a/app/src/main/java/org/opencord/igmpproxy/impl/IgmpSender.java b/app/src/main/java/org/opencord/igmpproxy/impl/IgmpSender.java
index 79aa80e..9152cec 100644
--- a/app/src/main/java/org/opencord/igmpproxy/impl/IgmpSender.java
+++ b/app/src/main/java/org/opencord/igmpproxy/impl/IgmpSender.java
@@ -17,8 +17,6 @@
 
 import org.onlab.packet.Ethernet;
 import org.onlab.packet.IGMP;
-import org.onlab.packet.IGMP.IGMPv2;
-import org.onlab.packet.IGMP.IGMPv3;
 import org.onlab.packet.IGMPMembership;
 import org.onlab.packet.IGMPQuery;
 import org.onlab.packet.IPv4;
@@ -269,15 +267,11 @@
 
         IPv4 ipv4Pkt = (IPv4) ethPkt.getPayload();
         IGMP igmp = (IGMP) ipv4Pkt.getPayload();
-        // We are checking the length of packets. Right now the counter value will be 0 because of internal translation
-        // As packet length will always be valid
-        // This counter will be useful in future if we change the procedure to generate the packets.
+        // We are checking the groups.
         if ((igmp.getIgmpType() == IGMP.TYPE_IGMPV2_MEMBERSHIP_REPORT
-             || igmp.getIgmpType() == IGMP.TYPE_IGMPV2_LEAVE_GROUP) && igmp.serialize().length < IGMPv2.HEADER_LENGTH) {
-                 igmpStatisticsService.increaseStat(IgmpStatisticType.INVALID_IGMP_LENGTH);
-        } else if (igmp.getIgmpType() == IGMP.TYPE_IGMPV3_MEMBERSHIP_REPORT
-            && igmp.serialize().length < IGMPv3.MINIMUM_HEADER_LEN) {
-                 igmpStatisticsService.increaseStat(IgmpStatisticType.INVALID_IGMP_LENGTH);
+                || igmp.getIgmpType() == IGMP.TYPE_IGMPV3_MEMBERSHIP_REPORT
+                || igmp.getIgmpType() == IGMP.TYPE_IGMPV2_LEAVE_GROUP) && igmp.getGroups().isEmpty()) {
+            igmpStatisticsService.increaseStat(IgmpStatisticType.INVALID_IGMP_LENGTH);
         }
         TrafficTreatment treatment = DefaultTrafficTreatment.builder()
                 .setOutput(portNumber).build();