commit 8a1491941353535e859eb209ff5bd4cba6aab3be
author Andrea Campanella <andrea@opennetworking.org> Fri Jul 31 17:19:45 2020 +0200
committer Andrea Campanella <andrea@opennetworking.org> Fri Jul 31 17:43:06 2020 +0200
tree 2fa07c9cad5e578e1f0d35ae35d3ccb6dba22226
parent dd94647da127ca97960ef5265aae09b3290b46cd

Adhering to best practices

Change-Id: I3a44e14b8c6b7566b3b2066ef8579e09d18ab4ba

voltha

diff --git a/voltha b/voltha
index 6e96939..684363a 100755
--- a/voltha
+++ b/voltha
@@ -1548,33 +1548,33 @@
         espin "$NOT_VERIFIED"
         bspin - "Generating cluster configuration"
 
-        file="$NAME-cluster.cfg"
+        FILE="$NAME-cluster.cfg"
 
-        if [ -f "$file" ] ; then
-          rm "$file"
+        if [ -f "$FILE" ] ; then
+          rm "$FILE"
         fi
 
-        touch "$NAME-cluster.cfg"
+        touch "$FILE"
 
-        yq w -i "$NAME-cluster.cfg" kind Cluster
-        yq w -i "$NAME-cluster.cfg" apiVersion "kind.sigs.k8s.io/v1alpha3"
+        yq w -i "$FILE" kind Cluster
+        yq w -i "$FILE" apiVersion "kind.sigs.k8s.io/v1alpha3"
 
         if [ ! "$NUM_OF_CONTROLLER_NODES" -eq 0 ]; then
           for instance in $(seq 1 "$NUM_OF_CONTROLLER_NODES"); do
-            yq w -i "$NAME-cluster.cfg" "nodes[+].role" "control-plane"
+            yq w -i "$FILE" "nodes[+].role" "control-plane"
           done
         fi
 
         if [ ! "$NUM_OF_WORKER_NODES" -eq 0 ]; then
           for instance in $(seq 1 "$NUM_OF_WORKER_NODES"); do
-            yq w -i "$NAME-cluster.cfg" "nodes[+].role" worker
+            yq w -i "$FILE" "nodes[+].role" worker
           done
         fi
         espin - "$VERIFIED"
 
-        cat "$NAME-cluster.cfg" >> "$LOG" 2>&1
+        cat "$FILE" >> "$LOG" 2>&1
 
-        kind create cluster --name "voltha-$NAME" --config "$NAME-cluster.cfg"
+        kind create cluster --name "voltha-$NAME" --config "$FILE"
      else
         espin "$VERIFIED"
     fi