commit 99dbed354d307430f166963aea300de67a1f03f3
author Matteo Scandolo <matteo.scandolo@gmail.com> Thu Sep 03 14:11:27 2020 -0700
committer Matteo Scandolo <matteo.scandolo@gmail.com> Thu Sep 03 14:11:27 2020 -0700
tree 4c6af2c47b3fc206887103a4ef5170d02b9798b6
parent 734fe96aeca1bfccb5038b2948083f1c16cbbdde

Addressing comments on 20209

Change-Id: I119c128635b5a0a2e6aea3c634baf18d31404f8f

voltha

diff --git a/voltha b/voltha
index 6eccbeb..5a96848 100755
--- a/voltha
+++ b/voltha
@@ -248,11 +248,11 @@
     return
 }
 
-# returns true if v1 is less than v2
+# returns true if v1 is greater than v2 (false if they are the same)
 function semver_greater() {
   local v1
   local v2
-  v1=("$1") v2=("$2")
+  v1="$1" v2="$2"
 
   # shellcheck disable=SC2128
   if [[ "$v1" == "latest" ]] || [[ "$v1" == "master" ]]; then
@@ -271,11 +271,11 @@
   fi
 }
 
-# returns true if v2 is less than v1
+# returns true if v1 is lesser than v2 (false if they are the same)
 function semver_lesser() {
   local v1
   local v2
-  v1=("$1") v2=("$2")
+  v1="$1" v2="$2"
 
   # shellcheck disable=SC2128
   if [[ "$v1" == "latest" ]] || [[ "$v1" == "master" ]]; then