CORD-391 - cleaned up ansible to pass cleanly through ansible-lint
Change-Id: I90284704255edc19abbdb239852c520a4bf48df4
diff --git a/roles/compute-node/tasks/i40e_driver.yml b/roles/compute-node/tasks/i40e_driver.yml
index 69c14cd..78bd3ef 100644
--- a/roles/compute-node/tasks/i40e_driver.yml
+++ b/roles/compute-node/tasks/i40e_driver.yml
@@ -21,6 +21,7 @@
command: make install
args:
chdir: i40e-1.4.25/src
+ changed_when: true
- name: Load i40e Driver
become: yes
diff --git a/roles/compute-node/tasks/main.yml b/roles/compute-node/tasks/main.yml
index f74ab55..ebbb1be 100644
--- a/roles/compute-node/tasks/main.yml
+++ b/roles/compute-node/tasks/main.yml
@@ -9,17 +9,17 @@
- name: Applications
become: yes
- apt: name={{ item }} state=latest force=yes
+ apt: name={{ item }} state=present force=yes
with_items:
- - build-essential
- - git
- - python-pip
- - ifenslave-2.6
- - bridge-utils
- - ethtool
- - minicom
- - curl
- - jq
+ - build-essential=11.6*
+ - git=1:1.9.*
+ - python-pip=1.5.4*
+ - ifenslave-2.6=2.4*
+ - bridge-utils=1.5-*
+ - ethtool=1:3.13*
+ - minicom=2.7*
+ - curl=7.35.*
+ - jq=1.4*
- name: Ensure Docker Insecure Repository
become: yes
@@ -139,13 +139,13 @@
- interface_config
- name: Update mlx4 Driver
- include: tasks/mlx4_driver.yml
+ include: mlx4_driver.yml
when: mlx_nic_present.stdout != "0" and mlx4_version.stdout != '3.1-1.0.4'
tags:
- interface_config
- name: Update i40e Driver
- include: tasks/i40e_driver.yml
+ include: i40e_driver.yml
when: intel_nic_present.stdout != "0" and i40e_version.stdout != '1.4.25'
tags:
- interface_config
diff --git a/roles/compute-node/tasks/mlx4_driver.yml b/roles/compute-node/tasks/mlx4_driver.yml
index 06219d2..a9b76f0 100644
--- a/roles/compute-node/tasks/mlx4_driver.yml
+++ b/roles/compute-node/tasks/mlx4_driver.yml
@@ -17,6 +17,7 @@
- name: Install mlx4 driver
become: yes
command: /tmp/mlnx-en-3.1-1.0.4/install.sh --batch
+ changed_when: true
- name: Remove Build Directory
become: yes