commit 160e8680449b4c41008d969dc6fd9ddc33e2155b
author Andy Bavier <andy@opennetworking.org> Tue May 07 18:32:22 2019 -0700
committer Andy Bavier <andy@opennetworking.org> Tue May 07 18:32:22 2019 -0700
tree 91f8cbab637e761cecd6815c9307d8a5ec7111a2
parent f59c0912147bd08632c393638ab1cded669a8b39

SEBA-633 Fix flow removal when port disabled

Change-Id: Ib2684f3d41d4b70c772f009e9227c688ed18b45b

app/src/main/java/org/opencord/olt/impl/Olt.java

diff --git a/app/src/main/java/org/opencord/olt/impl/Olt.java b/app/src/main/java/org/opencord/olt/impl/Olt.java
index 57e940a..9a3534f 100644
--- a/app/src/main/java/org/opencord/olt/impl/Olt.java
+++ b/app/src/main/java/org/opencord/olt/impl/Olt.java
@@ -413,8 +413,12 @@
         //re-install eapol
         processEapolFilteringObjectives(deviceId, subscriberPortNo,
                 subscriber.upstreamBandwidthProfile(), null, subscriber.cTag(), false);
-        processEapolFilteringObjectives(deviceId, subscriberPortNo, defaultBpId,
-                null, VlanId.vlanId(EAPOL_DEFAULT_VLAN), true);
+
+        Port port = deviceService.getPort(deviceId, subscriberPortNo);
+        if (port != null && port.isEnabled()) {
+            processEapolFilteringObjectives(deviceId, subscriberPortNo, defaultBpId,
+                    null, VlanId.vlanId(EAPOL_DEFAULT_VLAN), true);
+        }
 
         programmedSubs.remove(connectPoint);
         return true;
@@ -1140,9 +1144,11 @@
 
     private int getDefaultTechProfileId(DeviceId devId, PortNumber portNumber) {
         Port port = deviceService.getPort(devId, portNumber);
-        SubscriberAndDeviceInformation info = subsService.get(port.annotations().value(AnnotationKeys.PORT_NAME));
-        if (info != null && info.technologyProfileId() != -1) {
-            return info.technologyProfileId();
+        if (port != null) {
+            SubscriberAndDeviceInformation info = subsService.get(port.annotations().value(AnnotationKeys.PORT_NAME));
+            if (info != null && info.technologyProfileId() != -1) {
+                return info.technologyProfileId();
+            }
         }
         return defaultTechProfileId;
     }
@@ -1633,6 +1639,9 @@
                     case PORT_REMOVED:
                         if (isUniPort(dev, port)) {
                             removeSubscriber(new ConnectPoint(devId, port.number()));
+                            processEapolFilteringObjectives(devId, port.number(), defaultBpId,
+                                    null, VlanId.vlanId(EAPOL_DEFAULT_VLAN), false);
+
                             post(new AccessDeviceEvent(AccessDeviceEvent.Type.UNI_REMOVED, devId, port));
                         }