commit 34664e8f7f08ace6d242356aa7da6e2c12977f26
author Gustavo Silva <gsilva@furukawalatam.com> Mon Sep 19 13:28:09 2022 -0300
committer Gustavo Silva <gsilva@furukawalatam.com> Mon Oct 10 18:55:38 2022 +0000
tree b1148f23e870dcc3ca799ca34319b5339b6741cc
parent e9634f0f7b421f127db67abaab9adf5856bc1d35

Stopping considering default EAPOL with last status 'ERROR' as present

We noticed that during some jobs execution (e.g: onu mib template unknown me) the default EAPOL flow would not be reinstalled
after running into error during a previous uninstallation. The reason was because of the verification function 'hasDefaultEapol'.
It was considering the last status ERROR when evaluating if the default EAPOL flow was present. There was a comment justifying that rule,
however the premise was proven to be false. This patchset was made on that context.

Change-Id: Ifc3d802a3bc8e45ff75565647faa11d3ed212f8f
Signed-off-by: Gustavo Silva <gsilva@furukawalatam.com>

impl/src/main/java/org/opencord/olt/impl/OltFlowService.java

diff --git a/impl/src/main/java/org/opencord/olt/impl/OltFlowService.java b/impl/src/main/java/org/opencord/olt/impl/OltFlowService.java
index 9112f23..a339c87 100644
--- a/impl/src/main/java/org/opencord/olt/impl/OltFlowService.java
+++ b/impl/src/main/java/org/opencord/olt/impl/OltFlowService.java
@@ -656,11 +656,8 @@
     @Override
     public boolean hasDefaultEapol(Port port) {
         OltPortStatus status = getOltPortStatus(port, defaultEapolUniTag);
-        // NOTE we consider ERROR as a present EAPOL flow as ONOS
-        // will keep trying to add it
         return status != null && (status.defaultEapolStatus == OltFlowsStatus.ADDED ||
-                status.defaultEapolStatus == OltFlowsStatus.PENDING_ADD ||
-                status.defaultEapolStatus == OltFlowsStatus.ERROR);
+                status.defaultEapolStatus == OltFlowsStatus.PENDING_ADD);
     }
 
     private OltPortStatus getOltPortStatus(Port port, UniTagInformation uniTagInformation) {