commit 94b904929f9371cdaf1f2f9b8e91e30381ad079e
author Jonathan Hart <jono@opennetworking.org> Tue Apr 24 14:02:25 2018 -0700
committer Jonathan Hart <jono@opennetworking.org> Thu May 17 16:24:01 2018 +0000
tree e457b5e6705731272f201acb5a4b342d4d8112cb
parent e78d0114ab9dc4318f39f2dfc066e3bdaf28ef95

Report an error for invalid invocations of the add-subscriber command

Change-Id: I996c5efcabd7b83d8a8edb4e670f7d8649b9e309

app/src/main/java/org/opencord/olt/impl/Olt.java

diff --git a/app/src/main/java/org/opencord/olt/impl/Olt.java b/app/src/main/java/org/opencord/olt/impl/Olt.java
index a875245..8b71a0a 100644
--- a/app/src/main/java/org/opencord/olt/impl/Olt.java
+++ b/app/src/main/java/org/opencord/olt/impl/Olt.java
@@ -30,7 +30,6 @@
 import org.onlab.packet.VlanId;
 import org.onlab.util.Tools;
 import org.onosproject.cfg.ComponentConfigService;
-
 import org.onosproject.core.ApplicationId;
 import org.onosproject.core.CoreService;
 import org.onosproject.event.AbstractListenerManager;
@@ -39,7 +38,6 @@
 import org.onosproject.net.DeviceId;
 import org.onosproject.net.Port;
 import org.onosproject.net.PortNumber;
-
 import org.onosproject.net.config.ConfigFactory;
 import org.onosproject.net.config.NetworkConfigEvent;
 import org.onosproject.net.config.NetworkConfigListener;
@@ -61,14 +59,14 @@
 import org.onosproject.net.flowobjective.Objective;
 import org.onosproject.net.flowobjective.ObjectiveContext;
 import org.onosproject.net.flowobjective.ObjectiveError;
+import org.onosproject.store.serializers.KryoNamespaces;
+import org.onosproject.store.service.Serializer;
+import org.onosproject.store.service.StorageService;
 import org.opencord.cordconfig.access.AccessDeviceConfig;
 import org.opencord.cordconfig.access.AccessDeviceData;
 import org.opencord.olt.AccessDeviceEvent;
 import org.opencord.olt.AccessDeviceListener;
 import org.opencord.olt.AccessDeviceService;
-import org.onosproject.store.serializers.KryoNamespaces;
-import org.onosproject.store.service.Serializer;
-import org.onosproject.store.service.StorageService;
 import org.osgi.service.component.ComponentContext;
 import org.slf4j.Logger;
 
@@ -83,6 +81,7 @@
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
 
+import static com.google.common.base.Preconditions.checkNotNull;
 import static com.google.common.base.Strings.isNullOrEmpty;
 import static org.onlab.util.Tools.get;
 import static org.onlab.util.Tools.groupedThreads;
@@ -226,11 +225,13 @@
 
     @Override
     public void provisionSubscriber(ConnectPoint port, VlanId vlan) {
+        checkNotNull(deviceService.getPort(port.deviceId(), port.port()),
+                "Invalid connect point");
         AccessDeviceData olt = oltData.get(port.deviceId());
 
         if (olt == null) {
             log.warn("No data found for OLT device {}", port.deviceId());
-            return;
+            throw new IllegalArgumentException("Missing OLT configuration for device");
         }
 
         if (enableDhcpIgmpOnProvisioning) {