Update pom.xml to depend on official onos-dependencies parent pom
This patch fixes the issues seen when trying to release the app,
and in general, when trying to execute maven stages other than
build/install.
ONOS stopped publishing onos-dependencies with version 2.2.0, thus
requiring each app to explicitly declare dependencies and plugins. The
following ONOS patch revamps support for building 3rd-party apps with
Maven, including publishing of the onos-dependencies (parent) pom:
https://gerrit.onosproject.org/#/c/22790/
The new onos-dependencies exposes shared Java dependencies as well as
Maven plugins, already configured to support the whole life-cycle of
apps (from build, to reporting and release).
Change-Id: Ia127861651b65bbf67e70375fb48317edab5ade8
diff --git a/app/pom.xml b/app/pom.xml
index 2b3a216..e8b9da6 100644
--- a/app/pom.xml
+++ b/app/pom.xml
@@ -80,51 +80,21 @@
<dependency>
<groupId>org.apache.karaf.shell</groupId>
<artifactId>org.apache.karaf.shell.console</artifactId>
- <version>${karaf.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.karaf.shell</groupId>
<artifactId>org.apache.karaf.shell.core</artifactId>
- <version>${karaf.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
- <groupId>org.osgi</groupId>
- <artifactId>org.osgi.service.component.annotations</artifactId>
- <version>1.4.0</version>
- <scope>provided</scope>
- </dependency>
-
- <dependency>
- <groupId>org.osgi</groupId>
- <artifactId>org.osgi.compendium</artifactId>
- <version>5.0.0</version>
- <scope>provided</scope>
- </dependency>
-
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.12</version>
- <scope>test</scope>
- </dependency>
-
- <dependency>
<groupId>javax.ws.rs</groupId>
<artifactId>javax.ws.rs-api</artifactId>
- <version>2.1</version>
<scope>provided</scope>
</dependency>
- <dependency>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-api</artifactId>
- <version>1.7.25</version>
- <scope>provided</scope>
- </dependency>
</dependencies>
<build>
@@ -132,30 +102,6 @@
<plugin>
<groupId>org.onosproject</groupId>
<artifactId>onos-maven-plugin</artifactId>
- <version>2.2</version>
- <executions>
- <execution>
- <id>cfg</id>
- <phase>generate-resources</phase>
- <goals>
- <goal>cfg</goal>
- </goals>
- </execution>
- <execution>
- <id>swagger</id>
- <phase>generate-sources</phase>
- <goals>
- <goal>swagger</goal>
- </goals>
- </execution>
- <execution>
- <id>app</id>
- <phase>package</phase>
- <goals>
- <goal>app</goal>
- </goals>
- </execution>
- </executions>
</plugin>
<plugin>
@@ -168,15 +114,11 @@
WEB-INF/classes/apidoc/swagger.json=target/swagger.json,
{maven-resources}
</Include-Resource>
- <Bundle-SymbolicName>
- ${project.groupId}.${project.artifactId}
- </Bundle-SymbolicName>
<Import-Package>
*,org.glassfish.jersey.servlet
</Import-Package>
<Web-ContextPath>${web.context}</Web-ContextPath>
<Karaf-Commands>org.opencord.olt.cli</Karaf-Commands>
- <_dsannotations-options>inherit</_dsannotations-options>
</instructions>
</configuration>
</plugin>
diff --git a/app/src/main/java/org/opencord/olt/impl/Olt.java b/app/src/main/java/org/opencord/olt/impl/Olt.java
index 0aaa8bf..3775060 100644
--- a/app/src/main/java/org/opencord/olt/impl/Olt.java
+++ b/app/src/main/java/org/opencord/olt/impl/Olt.java
@@ -182,47 +182,47 @@
protected StorageService storageService;
/**
- * Default VLAN RG<->ONU traffic
+ * Default VLAN RG<->ONU traffic.
**/
private int defaultVlan = DEFAULT_VLAN_DEFAULT;
/**
- * Create the DHCP Flow rules when a subscriber is provisioned
+ * Create the DHCP Flow rules when a subscriber is provisioned.
**/
protected boolean enableDhcpOnProvisioning = ENABLE_DHCP_ON_PROVISIONING_DEFAULT;
/**
- * Enable flows for DHCP v4
+ * Enable flows for DHCP v4.
**/
protected boolean enableDhcpV4 = ENABLE_DHCP_V4_DEFAULT;
/**
- * Enable flows for DHCP v6
+ * Enable flows for DHCP v6.
**/
protected boolean enableDhcpV6 = ENABLE_DHCP_V6_DEFAULT;
/**
- * Create IGMP Flow rules when a subscriber is provisioned
+ * Create IGMP Flow rules when a subscriber is provisioned.
**/
protected boolean enableIgmpOnProvisioning = ENABLE_IGMP_ON_PROVISIONING_DEFAULT;
/**
- * Deleting Meters based on flow count statistics
+ * Deleting Meters based on flow count statistics.
**/
protected boolean deleteMeters = DELETE_METERS_DEFAULT;
/**
- * Default technology profile id that is used for authentication trap flows
+ * Default technology profile id that is used for authentication trap flows.
**/
protected int defaultTechProfileId = DEFAULT_TP_ID_DEFAULT;
/**
- * Default bandwidth profile id that is used for authentication trap flows
+ * Default bandwidth profile id that is used for authentication trap flows.
**/
protected String defaultBpId = DEFAULT_BP_ID_DEFAULT;
/**
- * Send EAPOL authentication trap flows before subscriber provisioning
+ * Send EAPOL authentication trap flows before subscriber provisioning.
**/
protected boolean enableEapol = ENABLE_EAPOL_DEFAULT;