| commit | ed6b9112e66ffc5106e738750735225885279998 | [log] [tgz] |
|---|---|---|
| author | Chip Boling <chipboling@gmail.com> | Tue May 11 09:14:54 2021 -0500 |
| committer | Chip Boling <chipboling@gmail.com> | Tue May 11 09:21:00 2021 -0500 |
| tree | 9c13a5e15a177b24efd78dfd54aeb38fb527f40b | |
| parent | 00a30d232abd27e5e7bbb813c7399facce44a04d [diff] |
VOL-4075: Bugfix for TestRequest MsgLayer type being set incorrectly during message layer decode. Change-Id: Ie6c785502913d140bdb1d774ace147d15ca592d2 VOL-4075: Bugfix for TestRequest MsgLayer type being set incorrectly during message layer decode. Change-Id: If70d40c8eee75bf04a9f1e4636a581781571379f
OMCI gopacket library supports the encoding and decoding of ITU G.988 OMCI messages. Support for the Baseline Message Set has been completed and work is underway to support the Extended Message Set format.
The following OMCI message types currently have been coded and are covered satisfactory by unit tests.
The following OMCI message types currently have been coded and are partially covered by unit tests, but work still remains for sufficient/better unit test coverage.
The following OMCI message types currently have been coded but do not have any unit test coverage.
The following OMCI message types currently have not been coded.
As mentioned earlier, support for the Extended Message Set is underway. Currently, the following Message Types have this support and are covered by unit tests:
The following provides a list of message types that will eventually support the Extended Message Set in the expected order of implementation. The priority was chosen based on speed improvement requests of operations and ease of implementation.
DownloadSectionRequest/Response
AlarmNotification
AttributeValueChange
TestResult
GetCurrentDataRequest/Response
MibResetRequest/Response
RebootRequest/Response
SynchronizeTimeRequest/Response
CreateRequest/Response
DeleteRequest/Response
SetRequest/Response
MibUploadRequest/Response
MibUploadNextRequest/Response
GetAllAlarmsRequest/Response
GetAllAlarmsNextRequest/Response
GetNextRequest/Response
StartSoftwareDownloadRequest/Response
EndSoftwareDownloadRequest/Response
CommitSoftwareRequest/Response
ActivateSoftwareRequest/Response
SetTableRequest/Response
TestRequest/Response
The make test command can be used to create code coverage support for the library. The current coverage for version 1.0.0 (as of 4/21/2021) is:
| File | Statement Coverage |
|---|---|
| layers.go | 100% |
| mebase.go | 91.7% |
| meframe.go | 50.8% |
| messagetypes.go | 59.1% |
| omci.go | 79.0% |
Besides OMCI Message decode/serialization, and associated unit tests, the following items would be needed or useful in a first official release of this library. Some changes are to be done in the generated OMCI ME code as well.
Also searching through the code for TODO statements will also yield additional areas of work to be performed.
This library is not a full OMCI stack for either an OLT or an ONU. It is focused primarily on packet decode/serialization and a variety of structs and functions that are useful for handling the creation of OMCI frames and handling decoded frames from the PON.
For an OLT-side OMCI stack, you would still need to write:
For an ONU-side OMCI stack, you would still need to write: