Gitiles
Code Review Sign In
gerrit.opencord.org / onf-make / 216b04b3c6bada846f240fb0eaf838dc30e77cc7
commit216b04b3c6bada846f240fb0eaf838dc30e77cc7[log] [tgz]
authorJoey Armstrong <joey@opennetworking.org>Fri Sep 29 16:31:19 2023 -0400
committerJoey Armstrong <joey@opennetworking.org>Fri Nov 10 11:57:43 2023 -0500
tree15b1791b3ad593e0d41a1549a6ae710bcbbee793
parenta8205c202e320b5f74e5b93de7c0ac2809dfc3c0 [diff]
Bulk filter undef vars to support makefile target lint-make

makefiles/include.mk
makefiles/lint/make/include.mk
makefiles/lint/make/makefile.mk
-------------------------------
  o Move lint-make target logic into makefiles/lint/make/

makefiles/lint/make/warn-undef-vars.mk
--------------------------------------
  o Volume undef warnings plague makefile linting.
  o Makefile logic cleanup needed but in the interim valid-but-undef
    vars are defined as "var := $(null)".  This helps shorten the
    error log so lint-make can be used as a default lint target.

Change-Id: I48a0c6b2c71cf1dd5a6554cc5823502ed88482d0
5 files changed
tree: 15b1791b3ad593e0d41a1549a6ae710bcbbee793
  1. .gitignore
  2. .gitreview
  3. Makefile
  4. README.md
  5. bin/
  6. config.mk
  7. docs/
  8. makefiles/
  9. makefiles_include_mk.ex
README.md

onf-make library makefiles

This repository contains common makefile logic and targets that can be used to build arbitrary repositories. Makefile logic is currently being consumed by the VOLTHA project

makefiles/ subdirectories

Two distinct sets of makefiles are needed to support builds:

  • The first is a subdir of makefiles/ named 'onf-make'

    • This directory exists and is maintained as a git-submodule of repo:onf-make.
    • Library makefiles contain independent logic to install common tools such as (virtualenv), perform linting tasks, define constants and perform path/string manipulation, etc.

  • The second makefile directory contains repository/project specific logic:

    • makefiles/local/ exists as a repository subdirectory under SCM.
    • Contains custom targets, variant parameters and custom logic specific to the repository it exists within.

  • Most makefile logic can be parameterized and implemented to support reuse. Consider adding enhancements or refactoring local/ makefile logic into repo:onf-make so all makefiles can leverage it.

Hierarchy

% tree --charset=ascii -n

Makefile
config.mk
makefiles/
|-- include.mk
|-- local
|   |-- include.mk
|   |   |   |-- doc8
|   |   |   |    |-- doc8.ini   (alas only one --config switch allowed)
|-- [onf-make: git-submodule](https://github.com/opencord/onf-make)
|   |-- makefiles
|   |   |-- consts.mk
|   |   |-- include.mk
|   |   |-- lint
|   |   |   |-- doc8            Syntax check ReStructuredText (rst) files
|   |   |   |-- groovy
|   |   |   |-- python
|   |   |   |-- robot.mk        Syntax check robot testing framework
|   |   |   |-- shell.mk        Invoke shellcheck command on scripts
|   |   |   |-- yaml            Syntax check yaml configs

NOTES

  • Ascii art was rendered using

    • tree --charset=ascii -n

  • README.md can be rendered locally using

    • pandoc README.md | lynx -stdin
    • make view

SEE ALSO