[VOL-5358] - build & test repo using new AMI image
makefiles/docker/include.mk
---------------------------
o get-cmd-docker-protoc-sh()
o Initial get-cmd() function required one path -v <mount> or --workdir.
o repo:voltha-protos requires multiple docker mounts so add a second
get-cmd() function that will accept a list of arguments/mounts.
o Makefile can override the definition of PROTOC_SH and GO_SH.
o Purge stray comments copied in as a placeholder from a repo Makefile,
can add these individually as needed.
o [TODO] Consider moving get-cmd() logic into named docker makefiles
if more functions are needed.
makefiles/virtualenv/requirements-txt.mk
----------------------------------------
o This was cute: user .bashrc, env can bleed through affecting python
module config and compiler flag selection.
o When installing packages using requirements.txt, sanitize the shell
to avoid stray interaction with user defined environment.
o In my case compiling would fail while attempting to construct a wheel
for packages being installed.
Signed-off-by: Joey Armstrong <jarmstrong@linuxfoundation.org>
Change-Id: Id1492807a505e54348b95bd553877565b55c57f6
diff --git a/makefiles/virtualenv/requirements-txt.mk b/makefiles/virtualenv/requirements-txt.mk
index 2d615f6..be66ea4 100644
--- a/makefiles/virtualenv/requirements-txt.mk
+++ b/makefiles/virtualenv/requirements-txt.mk
@@ -44,7 +44,7 @@
$(call banner-enter,venv-requirements)
@mkdir -p $(dir $@)
- $(activate) && python -m pip install -r 'requirements.txt'
+ /bin/bash --noprofile --norc -c "$(activate) && python -m pip install -r 'requirements.txt'"
@touch $@
$(call banner-leave,venv-requirements)