tree 1ed76c96e17c747893de22d795733adf7f5ffcf3
parent 71f39c26f988ef0698703c3deb32fd13c4459d06
author Joey Armstrong <joey@opennetworking.org> 1695935913 -0400
committer Joey Armstrong <joey@opennetworking.org> 1696253606 +0000

Enhance shellcheck lint target (3 of 3 -- lint-shell target logic)

makefiles/lint/shell/help.mk
----------------------------
  o Top level include used to source all lint-shell library makefiles.
  o Loosely based on makefiles/{groovy,doc8}/*.
  o Currently library makefile makefiles/shell.mk deprecation pending.
  o Prefix yet-to-be-added makefile includes with hyphen to prevent errors.

makefiles/lint/shell/shellcheck.sh
----------------------------------
  o Enhance makefiles/shell.mk to support more lint targets.
  o Three targets are now supported:
    - lint-shell-all   current behavior, run shellcheck on all sources
    - lint-shell-mod   new: lint locally modified files (~git status)
    - lint-shell-src   new: run shellcheck on a list of files passed in.
  o Added helper function gen-lint-shell-deps:
    - generate a list of dependency based on makefile target.
    - dependency list is assigned to a variable named for the target.
    - avoids having to inline duplicate construction around targets.
  o Each target lint-shell-{all,mod,src} defines a list of
    dependencies/files to launch shellcheck on.
  o Target dependency lists allowed replacing "find | xargs shellcheck"
    commands with an explicit per-source-to-check target.
  o Structure will also allow supporting exclusion lists in the future.

unit-testing:
Helper script mcheck.sh will create a usable sandbox from shellcheck patches to evaluate targets.
shellcheck (make lint-shell*) will report problems in bin/setup.sh:
  o https://wiki.opennetworking.org/display/VOLTHA/repo%3Aonf-make

Change-Id: Id6ed1f66f80e63b4cc1c857f56c1fa342635df62