Improve target coverage for the reuse license checker.
misc
----
o Copyright notice update from onf v1 to onf v1.1
makefiles/etc/utils.mk
----------------------
o Function path-by-makefilepath-by-makefile():
- Replace $(subst include.mk) with $(dir) so path construction becomes generic.
- Added wrapper function genpath-makefiles() to improve call usability.
makefiles/lint/license/include.mk
makefiles/lint/license/reuse.mk
makefiles/lint/license/install.mk
---------------------------------
o Added requirements.txt for reuse tool install (ability to vesion and freeze for release).
o Define command var REUSE= so local devs can override.
o Added banner-{enter,leave} for logfile visibility.
makefiles/lint/license/include.mk
makefiles/lint/license/help.mk
------------------------------
o Document a few missing targets for 'make help' and 'make lint-reuse-help'.
[HOWTO: test]
-------------
% make sterile
% make venv # install virtualenv
% make lint-reuse-install
% make sterile
% make lint-reuse-version
% make sterile
% make lint-reuse
Change-Id: I91f4789981f3d3c5bc744d2db99374f9790e3b98
diff --git a/makefiles/lint/license/install.mk b/makefiles/lint/license/install.mk
index c708482..abaa778 100644
--- a/makefiles/lint/license/install.mk
+++ b/makefiles/lint/license/install.mk
@@ -1,6 +1,6 @@
# -*- makefile -*-
# -----------------------------------------------------------------------
-# Copyright 2022-2023 Open Networking Foundation (ONF) and the ONF Contributors
+# Copyright 2022-2024 Open Networking Foundation Contributors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
@@ -13,30 +13,24 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
-#
-# SPDX-FileCopyrightText: 2022 Open Networking Foundation (ONF) and the ONF Contributors
+# -----------------------------------------------------------------------
+# SPDX-FileCopyrightText: 2022-2024 Open Networking Foundation Contributors
# SPDX-License-Identifier: Apache-2.0
# -----------------------------------------------------------------------
+## Intent: This makefile will install the reuse tool used for license checking
+## -----------------------------------------------------------------------
$(if $(DEBUG),$(warning ENTER))
## -----------------------------------------------------------------------
-## Intent: Install the reuse tool
-## -----------------------------------------------------------------------
-
-## Define a macro to standardize and simplify access
-# REUSE ?= $(venv-activate-bin)/reuse
-# REUSE ?= $(activate) && reuse
-
-## -----------------------------------------------------------------------
## Intent: Display reuse command version string.
## Note: As a side effect, install reuse by dependency
## -----------------------------------------------------------------------
-.PHONY: lint-reuse-cmd-version
-lint-reuse-cmd-version : $(venv-activate-bin)/reuse
+.PHONY: lint-reuse-version
+lint-reuse-version : lint-reuse-install
$(HIDE) echo
- $< --version
+ $(venv-activate-bin)/reuse --version
## -----------------------------------------------------------------------
## Intent: On-demand instalation of the reuse command
@@ -61,9 +55,19 @@
help::
@printf ' %-30s %s\n' 'lint-reuse-install'\
'Install the reuse compliance tool'
+ @printf ' %-30s %s\n' 'lint-reuse-version'\
+ 'Display version of the installed reuse tool'
+
+# [NOTES]
+## -----------------------------------------------------------------------
+## o Installable tool target explicitly defined as $(venv-activate-bin)/reuse.
+## o Var $(REUSE) is not used as a dependency due to arbitray command
+## assignment with arguments. ie: make REUSE=/opt/reuse/bin/reuse
+## -----------------------------------------------------------------------
# [SEE ALSO]
# -----------------------------------------------------------------------
# o https://github.com/fsfe/reuse-tool#install
+## -----------------------------------------------------------------------
# [EOF]