Gitiles
Code Review Sign In
gerrit.opencord.org / onf-make / 0003f1a36b973973b5fc627363590d007d064cad
commit0003f1a36b973973b5fc627363590d007d064cad[log] [tgz]
authorJoey Armstrong <joey@opennetworking.org>Wed Oct 18 16:40:23 2023 -0400
committerJoey Armstrong <joey@opennetworking.org>Wed Oct 18 16:40:23 2023 -0400
tree3efb16f4b120d592de0342e43700918f316ca7dd
parent85e34514a552ca664da07027910c380bc692cbc7 [diff]
[VOL-5194] - Add missing copyright notice for license check

bin/setup.sh
------------
  o This script is only used interactively, no potential job fallout.
  o Added helper function banner and error.
  o Added source comments.
  o Added banner() calls to hilight script progression.
  o polish: git add created content for pending commit.

Change-Id: I637d58f3e983b6cb1b7f08d19f16da925a579668
1 file changed
tree: 3efb16f4b120d592de0342e43700918f316ca7dd
  1. .gitignore
  2. .gitreview
  3. Makefile
  4. README.md
  5. bin/
  6. config.mk
  7. makefiles/
  8. makefiles_include_mk.ex
README.md

onf-make library makefiles

This repository contains common makefile logic and targets that can be used to build arbitrary repositories. Makefile logic is currently being consumed by the VOLTHA project

makefiles/ subdirectories

Two distinct sets of makefiles are needed to support builds:

  • The first is a subdir of makefiles/ named 'onf-make'

    • This directory exists and is maintained as a git-submodule of repo:onf-make.
    • Library makefiles contain independent logic to install common tools such as (virtualenv), perform linting tasks, define constants and perform path/string manipulation, etc.

  • The second makefile directory contains repository/project specific logic:

    • makefiles/local/ exists as a repository subdirectory under SCM.
    • Contains custom targets, variant parameters and custom logic specific to the repository it exists within.

  • Most makefile logic can be parameterized and implemented to support reuse. Consider adding enhancements or refactoring local/ makefile logic into repo:onf-make so all makefiles can leverage it.

Hierarchy

% tree --charset=ascii -n

Makefile
config.mk
makefiles/
|-- include.mk
|-- local
|   |-- include.mk
|   |   |   |-- doc8
|   |   |   |    |-- doc8.ini   (alas only one --config switch allowed)
|-- [onf-make: git-submodule](https://github.com/opencord/onf-make)
|   |-- makefiles
|   |   |-- consts.mk
|   |   |-- include.mk
|   |   |-- lint
|   |   |   |-- doc8            Syntax check ReStructuredText (rst) files
|   |   |   |-- groovy
|   |   |   |-- python
|   |   |   |-- robot.mk        Syntax check robot testing framework
|   |   |   |-- shell.mk        Invoke shellcheck command on scripts
|   |   |   |-- yaml            Syntax check yaml configs

TODO

  • Refactor and merge logic from available repository makefiles/ directories.

  • Update to make use of library makefiles

    • setup.sh
    • {repository}/makefiles/{local, onf-make}/
    • Create config.mk to enable targets and features.

  • Exercise make lint targets, bulk cleanup is needed across all repositories.

  • Relocate $sandbox/config.mk into makefiles/config.mk

NOTES

  • Ascii art was rendered using

    • tree --charset=ascii -n

  • README.md can be rendered locally using

    • pandoc README.md | lynx -stdin