bgpd, lib: memory cleanups for valgrind, plus debug changes
Description:
We use valgrind memcheck quite a bit to spot leaks in
our work with bgpd. In order to eliminate false positives,
we added code in the exit path to release the remaining
allocated memory.
Bgpd startup log message now includes pid.
Some little tweaks by Paul Jakma <paul.jakma@hpe.com>:
* bgp_mplsvpn.c: (str2prefix_rd) do the cleanup in common code at the end
and goto it.
diff --git a/bgpd/bgpd.c b/bgpd/bgpd.c
index 3fdd9ff..90e77f2 100644
--- a/bgpd/bgpd.c
+++ b/bgpd/bgpd.c
@@ -737,6 +737,9 @@
if (peer->clear_node_queue)
work_queue_free (peer->clear_node_queue);
+ if (peer->notify.data)
+ XFREE(MTYPE_TMP, peer->notify.data);
+
bgp_sync_delete (peer);
memset (peer, 0, sizeof (struct peer));
@@ -1988,7 +1991,7 @@
struct bgp *
bgp_get_default (void)
{
- if (bm->bgp->head)
+ if (bm && bm->bgp && bm->bgp->head)
return (listgetdata (listhead (bm->bgp)));
return NULL;
}