commit 0ee8a1f1d61ce55642d9164625ab36700fe2c3a9
author Matthieu Boutier <boutier@pps.jussieu.fr> Wed Jan 18 00:52:06 2012 +0100
committer Paul Jakma <paul@quagga.net> Sun Mar 25 17:06:52 2012 +0100
tree 1bb2592f6386b38bb6254cd7d6267a2cde056275
parent 4eedea551290906fc76f3a0c908ae759e78bb68a

babeld: avoid segfault (bug 706).

babeld/babel_interface.c

diff --git a/babeld/babel_interface.c b/babeld/babel_interface.c
index b80bf94..edfa2b4 100644
--- a/babeld/babel_interface.c
+++ b/babeld/babel_interface.c
@@ -486,6 +486,13 @@
     int mtu, rc;
     struct ipv6_mreq mreq;
 
+    if (!if_is_operative(ifp) || !CHECK_FLAG(ifp->flags, IFF_RUNNING)) {
+        interface_reset(ifp);
+        return -1;
+    }
+
+    babel_ifp->flags |= BABEL_IF_IS_UP;
+
     mtu = MIN(ifp->mtu, ifp->mtu6);
 
     /* We need to be able to fit at least two messages into a packet,
@@ -577,6 +584,9 @@
     struct ipv6_mreq mreq;
     babel_interface_nfo *babel_ifp = babel_get_if_nfo(ifp);
 
+    debugf(BABEL_DEBUG_IF, "interface reset: %s", ifp->name);
+    babel_ifp->flags &= ~BABEL_IF_IS_UP;
+
     flush_interface_routes(ifp, 0);
     babel_ifp->buffered = 0;
     babel_ifp->bufsize = 0;

babeld/babel_interface.h

diff --git a/babeld/babel_interface.h b/babeld/babel_interface.h
index 7a6efb9..d9fb9a4 100644
--- a/babeld/babel_interface.h
+++ b/babeld/babel_interface.h
@@ -90,12 +90,15 @@
 #define BABEL_IF_SPLIT_HORIZON (1 << 2)
 #define BABEL_IF_LQ            (1 << 3)
 #define BABEL_IF_IS_ENABLE     (1 << 4)
+#define BABEL_IF_IS_UP         (1 << 5)
 
 static inline int
 if_up(struct interface *ifp)
 {
-    return (if_is_up(ifp) &&
+    return (if_is_operative(ifp) &&
             ifp->connected != NULL &&
+            babel_get_if_nfo(ifp) != NULL &&
+            (babel_get_if_nfo(ifp)->flags & BABEL_IF_IS_UP) &&
             (babel_get_if_nfo(ifp)->flags & BABEL_IF_IS_ENABLE));
 }