commit 135ca1502cc54d9ad00b60b3410a0932bfeceb29
author Lou Berger <lberger@labn.net> Tue Jan 12 13:42:05 2016 -0500
committer Paul Jakma <paul.jakma@hpe.com> Fri Feb 26 14:11:44 2016 +0000
tree 5bffa5f6cc373e3c5d4522768a52973b6bb8973c
parent a3fda886cdd48b6d8c421ebb1401142fa9ee93b0

bgpd: cleanup vty bgp_node_afi/safi utils

Signed-off-by: Lou Berger <lberger@labn.net>

bgpd/bgp_vty.c

diff --git a/bgpd/bgp_vty.c b/bgpd/bgp_vty.c
index 1a1a9b9..94796c7 100644
--- a/bgpd/bgp_vty.c
+++ b/bgpd/bgp_vty.c
@@ -57,17 +57,20 @@
 afi_t
 bgp_node_afi (struct vty *vty)
 {
+  afi_t afi;
   switch (vty->node)
     {
     case BGP_IPV6_NODE:
     case BGP_IPV6M_NODE:
     case BGP_VPNV6_NODE:
     case BGP_ENCAPV6_NODE:
-      return AFI_IP6;
+      afi = AFI_IP6;
+      break;
+    default:
+      afi = AFI_IP;
       break;
     }
-
-  return AFI_IP;
+  return afi;
 }
 
 /* Utility function to get subsequent address family from current
@@ -75,17 +78,26 @@
 safi_t
 bgp_node_safi (struct vty *vty)
 {
-  if (vty->node == BGP_ENCAP_NODE)
-    return SAFI_ENCAP;
-  if (vty->node == BGP_ENCAPV6_NODE)
-    return SAFI_ENCAP;
-  if (vty->node == BGP_VPNV6_NODE)
-    return SAFI_MPLS_VPN;
-  if (vty->node == BGP_VPNV4_NODE)
-    return SAFI_MPLS_VPN;
-  if (vty->node == BGP_IPV4M_NODE || vty->node == BGP_IPV6M_NODE)
-    return SAFI_MULTICAST;
-  return SAFI_UNICAST;
+  safi_t safi;
+  switch (vty->node)
+    {
+    case BGP_ENCAP_NODE:
+    case BGP_ENCAPV6_NODE:
+      safi = SAFI_ENCAP;
+      break;
+    case BGP_VPNV4_NODE:
+    case BGP_VPNV6_NODE:
+      safi = SAFI_MPLS_VPN;
+      break;
+    case BGP_IPV4M_NODE:
+    case BGP_IPV6M_NODE:
+      safi = SAFI_MULTICAST;
+      break;
+    default:
+      safi = SAFI_UNICAST;
+      break;
+  }
+  return safi;
 }
 
 int