lib: don't create circular lists (fixes 6d83113)
LISTNODE_DETACH doesn't clear out the node, and LISTNODE_ATTACH doesn't
set ->next (since it assumes a fresh/zeroed listnode). As a result, the
new listnode_move_to_tail() created a nice circular list, in turn
crashing ospfd in ospf_write() later.
Reported-by: Martin Winter <mwinter@netdef.org>
Fixes: 6d83113 ("ospfd: Tweak previous iface RR write patch to avoid free/malloc & redundant log")
Cc: Paul Jakma <paul@opensourcerouting.org>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Acked-by: Greg Troxel <gdt@ir.bbn.com>
Acked-by: Dinesh Dutt <ddutt@cumulusnetworks.com>
Acked-by: Vincent JARDIN <vincent.jardin@6wind.com>
diff --git a/lib/linklist.h b/lib/linklist.h
index c8d715e..6209c8b 100644
--- a/lib/linklist.h
+++ b/lib/linklist.h
@@ -113,6 +113,7 @@
#define LISTNODE_ATTACH(L,N) \
do { \
(N)->prev = (L)->tail; \
+ (N)->next = NULL; \
if ((L)->head == NULL) \
(L)->head = (N); \
else \