commit 2153090340f059eb787d72ba973ea55e150e9dec
author Daniel Walton <dwalton@cumulusnetworks.com> Tue May 19 18:03:38 2015 -0700
committer Paul Jakma <paul.jakma@hpe.com> Tue Oct 04 13:07:51 2016 +0100
tree 42fa35eb7553402425ce6e836bed00aa828a7ef6
parent 4c7efde6db75229069be72b34a93f279fe57d23b

bgpd: Fix BGP_INFO_ATTR_CHANGED being cleared incorrectly

back to back route refreshes can set BGP_INFO_ATTR_CHANGED
on the first route refresh but then clear it on the second

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

bgpd/bgp_route.c

diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c
index 7f98f94..eedb2a0 100644
--- a/bgpd/bgp_route.c
+++ b/bgpd/bgp_route.c
@@ -1990,7 +1990,6 @@
           && attrhash_cmp (ri->attr, attr_new))
         {
 
-          bgp_info_unset_flag (rn, ri, BGP_INFO_ATTR_CHANGED);
 
           if (BGP_DEBUG (update, UPDATE_IN))
             zlog (peer->log, LOG_DEBUG,
@@ -2244,8 +2243,6 @@
       if (!CHECK_FLAG (ri->flags, BGP_INFO_REMOVED) 
           && attrhash_cmp (ri->attr, attr_new))
 	{
-	  bgp_info_unset_flag (rn, ri, BGP_INFO_ATTR_CHANGED);
-
 	  if (CHECK_FLAG (bgp->af_flags[afi][safi], BGP_CONFIG_DAMPENING)
 	      && peer->sort == BGP_PEER_EBGP
 	      && CHECK_FLAG (ri->flags, BGP_INFO_HISTORY))