tree 1d7c03380a8a9a34e71f52e841bed2a81bece36b
parent bd4b7f1559ab5cb52bbe9dc2db9e50a032ccdbb7
author Dinesh G Dutt <ddutt@cumulusnetworks.com> 1422780972 -0800
committer Paul Jakma <paul@quagga.net> 1443104802 +0100

bgpd: Only use routes from Established peers for best path selection

Ensure that routes from a peer are not considered for best path
comparison if the peer is not in an Established state. There can
be a window between a peer being deleted and the background
thread that actually clears the routes (marks them as "removed")
runs during which best path may run. If this path selection
compared two prefixes all the way down to peer IP addresses and
one of these two peers had just been deleted, that peer would
not have its sockunion structures, especially su_remote, resulting
in a BGPD exception.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>