bgpd: don't leak memory in community_regexp_include
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
Acked-by: Donald Sharp <sharpd@cumulusnetworks.com>
diff --git a/bgpd/bgp_clist.c b/bgpd/bgp_clist.c
index 1f1a4e7..800bd01 100644
--- a/bgpd/bgp_clist.c
+++ b/bgpd/bgp_clist.c
@@ -402,17 +402,22 @@
static int
community_regexp_include (regex_t * reg, struct community *com, int i)
{
- const char *str;
+ char *str;
+ int rv;
/* When there is no communities attribute it is treated as empty
* string. */
if (com == NULL || com->size == 0)
- str = "";
+ str = XSTRDUP(MTYPE_COMMUNITY_STR, "");
else
str = community_str_get (com, i);
/* Regular expression match. */
- if (regexec (reg, str, 0, NULL, 0) == 0)
+ rv = regexec (reg, str, 0, NULL, 0);
+
+ XFREE(MTYPE_COMMUNITY_STR, str);
+
+ if (rv == 0)
return 1;
/* No match. */