2005-05-06 Paul Jakma <paul.jakma@sun.com>
* (general) extern and static qualifiers added.
unspecified arguments in definitions fixed, typically they should
be 'void'.
function casts added for callbacks.
Guards added to headers which lacked them.
Proper headers included rather than relying on incomplete
definitions.
gcc noreturn function attribute where appropriate.
* ospf_opaque.c: remove the private definition of ospf_lsa's
ospf_lsa_refresh_delay.
* ospf_lsa.h: export ospf_lsa_refresh_delay
* ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
correct thing to do - removes need for the casts later.
* ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
home-brewed versions, shuts up several warnings.
* ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
VTY_GET_IPV4_PREFIX moved to lib/vty.h.
* ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
overloading of the THREAD_ARG pointer should at least use
uintptr_t.
diff --git a/ospfd/ospf_apiserver.c b/ospfd/ospf_apiserver.c
index 59233c7..f9df812 100644
--- a/ospfd/ospf_apiserver.c
+++ b/ospfd/ospf_apiserver.c
@@ -767,7 +767,7 @@
* -----------------------------------------------------------
*/
-int
+static int
ospf_apiserver_send_msg (struct ospf_apiserver *apiserv, struct msg *msg)
{
struct msg_fifo *fifo;
@@ -992,7 +992,7 @@
}
-int
+static int
apiserver_is_opaque_type_registered (struct ospf_apiserver *apiserv,
u_char lsa_type, u_char opaque_type)
{
@@ -1268,7 +1268,7 @@
* -----------------------------------------------------------
*/
-int
+static int
apiserver_sync_callback (struct ospf_lsa *lsa, void *p_arg, int int_arg)
{
struct ospf_apiserver *apiserv;
@@ -1997,7 +1997,7 @@
}
/* Flush self-originated opaque LSA */
-int
+static int
apiserver_flush_opaque_type_callback (struct ospf_lsa *lsa,
void *p_arg, int int_arg)
{
@@ -2482,7 +2482,7 @@
msg_free (msg);
}
-void
+static void
apiserver_clients_lsa_change_notify (u_char msgtype, struct ospf_lsa *lsa)
{
struct msg *msg;
@@ -2583,7 +2583,7 @@
*/
-int
+static int
apiserver_notify_clients_lsa (u_char msgtype, struct ospf_lsa *lsa)
{
struct msg *msg;