2005-05-06 Paul Jakma <paul.jakma@sun.com>
* (general) extern and static qualifiers added.
unspecified arguments in definitions fixed, typically they should
be 'void'.
function casts added for callbacks.
Guards added to headers which lacked them.
Proper headers included rather than relying on incomplete
definitions.
gcc noreturn function attribute where appropriate.
* ospf_opaque.c: remove the private definition of ospf_lsa's
ospf_lsa_refresh_delay.
* ospf_lsa.h: export ospf_lsa_refresh_delay
* ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
correct thing to do - removes need for the casts later.
* ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
home-brewed versions, shuts up several warnings.
* ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
VTY_GET_IPV4_PREFIX moved to lib/vty.h.
* ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
overloading of the THREAD_ARG pointer should at least use
uintptr_t.
diff --git a/ospfd/ospf_main.c b/ospfd/ospf_main.c
index 7955162..b0ad3ab 100644
--- a/ospfd/ospf_main.c
+++ b/ospfd/ospf_main.c
@@ -105,7 +105,7 @@
#endif /* SUPPORT_OSPF_API */
/* Help information display. */
-static void
+static void __attribute__ ((noreturn))
usage (char *progname, int status)
{
if (status != 0)
@@ -131,14 +131,14 @@
}
/* SIGHUP handler. */
-void
+static void
sighup (void)
{
zlog (NULL, LOG_INFO, "SIGHUP received");
}
/* SIGINT handler. */
-void
+static void __attribute__ ((noreturn))
sigint (void)
{
zlog_notice ("Terminating on signal");
@@ -149,7 +149,7 @@
}
/* SIGUSR1 handler. */
-void
+static void
sigusr1 (void)
{
zlog_rotate (NULL);