2005-05-06 Paul Jakma <paul.jakma@sun.com>
* (general) extern and static qualifiers added.
unspecified arguments in definitions fixed, typically they should
be 'void'.
function casts added for callbacks.
Guards added to headers which lacked them.
Proper headers included rather than relying on incomplete
definitions.
gcc noreturn function attribute where appropriate.
* ospf_opaque.c: remove the private definition of ospf_lsa's
ospf_lsa_refresh_delay.
* ospf_lsa.h: export ospf_lsa_refresh_delay
* ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
correct thing to do - removes need for the casts later.
* ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
home-brewed versions, shuts up several warnings.
* ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
VTY_GET_IPV4_PREFIX moved to lib/vty.h.
* ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
overloading of the THREAD_ARG pointer should at least use
uintptr_t.
diff --git a/ospfd/ospf_route.c b/ospfd/ospf_route.c
index ca39d9b..00733d8 100644
--- a/ospfd/ospf_route.c
+++ b/ospfd/ospf_route.c
@@ -74,7 +74,7 @@
return new;
}
-struct ospf_path *
+static struct ospf_path *
ospf_path_dup (struct ospf_path *path)
{
struct ospf_path *new;
@@ -177,7 +177,7 @@
/* delete routes generated from AS-External routes if there is a inter/intra
* area route
*/
-void
+static void
ospf_route_delete_same_ext(struct route_table *external_routes,
struct route_table *routes)
{
@@ -208,7 +208,7 @@
}
/* rt: Old, cmprt: New */
-void
+static void
ospf_route_delete_uniq (struct route_table *rt, struct route_table *cmprt)
{
struct route_node *rn;
@@ -270,7 +270,7 @@
}
}
-void
+static void
ospf_intra_route_add (struct route_table *rt, struct vertex *v,
struct ospf_area *area)
{
@@ -709,7 +709,7 @@
o Intra-area paths using non-backbone areas are always the most preferred.
o The other paths, intra-area backbone paths and inter-area paths,
are of equal preference. */
-int
+static int
ospf_asbr_route_cmp (struct ospf *ospf, struct ospf_route *r1,
struct ospf_route *r2)
{
@@ -778,7 +778,7 @@
return (r1->cost - r2->cost);
}
-int
+static int
ospf_path_exist (struct list *plist, struct in_addr nexthop,
struct ospf_interface *oi)
{