commit 53d9f67a18dc59fd688fce999cb35653010a54fb
author Paul Jakma <paul.jakma@sun.com> Sun Oct 15 23:41:16 2006 +0000
committer Paul Jakma <paul.jakma@sun.com> Sun Oct 15 23:41:16 2006 +0000
tree 8412f230b56f658361b99f773395157703bcad7d
parent dcdf399fbc7420d3edc230c9646f720825fcecda

[bgpd] CID#73, potential crash in bgp statistics if called for AFI/SAFI with emtpy table

2006-10-15 Paul Jakma <paul.jakma@sun.com>

	* bgp_route.c: (bgp_table_stats_walker) NULL deref if table is
	  empty, bgp_table_top may return NULL, Coverity CID#73.

bgpd/bgp_route.c

diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c
index cd28b4d..7b36974 100644
--- a/bgpd/bgp_route.c
+++ b/bgpd/bgp_route.c
@@ -8481,7 +8481,8 @@
   struct bgp_table_stats *ts = THREAD_ARG (t);
   unsigned int space = 0;
   
-  top = bgp_table_top (ts->table);
+  if (!(top = bgp_table_top (ts->table)))
+    return 0;
 
   switch (top->p.family)
     {