commit 5477ee7b9d8d24d2bb61335c62f3d6c5e99fc901
author Paul Jakma <paul@jakma.org> Wed Jan 11 11:18:22 2017 +0000
committer Paul Jakma <paul@quagga.net> Thu Jan 19 13:22:50 2017 +0000
tree e594369217510323b34f6d8bfe6cd0fda4bc7674
parent 258f3dad6471a680c2c583a300cfd396efe9a037

Revert "opsf6d: Update router-LSA when nbr's interface-ID changes"

This reverts commit e509af86e3579944b7cde942ca3ee3427db1936a.

See Bug #885

ospf6d/ospf6_message.c

diff --git a/ospf6d/ospf6_message.c b/ospf6d/ospf6_message.c
index 439f6a6..d382f03 100644
--- a/ospf6d/ospf6_message.c
+++ b/ospf6d/ospf6_message.c
@@ -245,7 +245,6 @@
   char *p;
   int twoway = 0;
   int neighborchange = 0;
-  int neighbor_ifindex_change = 0;
   int backupseen = 0;
 
   hello = (struct ospf6_hello *)
@@ -286,17 +285,10 @@
       on->priority = hello->priority;
     }
 
-  /* Always override neighbor's source address */
+  /* always override neighbor's source address and ifindex */
+  on->ifindex = ntohl (hello->interface_id);
   memcpy (&on->linklocal_addr, src, sizeof (struct in6_addr));
 
-  /* Neighbor ifindex check */
-  if (on->ifindex > 0 
-      && (unsigned int) on->ifindex != ntohl (hello->interface_id))
-    {
-      on->ifindex = ntohl (hello->interface_id);
-      neighbor_ifindex_change++;
-    }
-
   /* TwoWay check */
   for (p = (char *) ((caddr_t) hello + sizeof (struct ospf6_hello));
        p + sizeof (u_int32_t) <= OSPF6_MESSAGE_END (oh);
@@ -356,9 +348,6 @@
     thread_add_event (master, backup_seen, oi, 0);
   if (neighborchange)
     thread_add_event (master, neighbor_change, oi, 0);
-
-  if (neighbor_ifindex_change && on->state == OSPF6_NEIGHBOR_FULL)
-    OSPF6_ROUTER_LSA_SCHEDULE (oi->area);
 }
 
 static void