Fixing crash fix attempt. It's still mess and logic is wrong and ... but at
least periodic spf works again.
diff --git a/isisd/isis_spf.c b/isisd/isis_spf.c
index 1987e0d..1e414c6 100644
--- a/isisd/isis_spf.c
+++ b/isisd/isis_spf.c
@@ -942,12 +942,18 @@
spftree->lastrun = time (NULL);
spftree->pending = 0;
- if (level == 1)
+ if (level == 1) {
+ /* FIXME: Should do it earlier. */
+ spftree->t_spf_periodic = NULL;
THREAD_TIMER_ON(master, spftree->t_spf_periodic, isis_run_spf_l1, area,
isis_jitter(PERIODIC_SPF_INTERVAL, 10));
- else
+ }
+ else {
+ /* FIXME: Should do it earlier. */
+ spftree->t_spf_periodic = NULL;
THREAD_TIMER_ON(master, spftree->t_spf_periodic, isis_run_spf_l2, area,
isis_jitter(PERIODIC_SPF_INTERVAL, 10));
+ }
return retval;
}
@@ -1039,7 +1045,7 @@
}
/* FIXME: This stuff is just mess. All spf thread add/cancel
logic should be reviewed. */
- /* THREAD_TIMER_OFF(spftree->t_spf_periodic); */
+ THREAD_TIMER_OFF(spftree->t_spf_periodic);
if (diff < MINIMUM_SPF_INTERVAL) {
if (level == 1)