commit 682ca04c4032bfbf31e51df2472345fda1ff7b2c
author Jorge Boncompte [DTI2] <jorge@dti2.net> Tue Apr 10 16:57:27 2012 +0200
committer David Lamparter <equinox@diac24.net> Wed May 02 17:03:34 2012 +0200
tree ec75a530cd72d30b41f90c2ddbd2878791e3f95f
parent 37beff6feb7c1715a19b59b8a87edcb6b50d5ac2

bgpd: cleanup, use correct buffer sizes for sockunion2str()

Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net>
Signed-off-by: David Lamparter <equinox@diac24.net>

bgpd/bgp_fsm.c

diff --git a/bgpd/bgp_fsm.c b/bgpd/bgp_fsm.c
index 813e59e..d920045 100644
--- a/bgpd/bgp_fsm.c
+++ b/bgpd/bgp_fsm.c
@@ -597,8 +597,6 @@
 static int
 bgp_connect_success (struct peer *peer)
 {
-  char buf1[BUFSIZ];
-
   if (peer->fd < 0)
     {
       zlog_err ("bgp_connect_success peer's fd is negative value %d",
@@ -612,6 +610,8 @@
 
   if (BGP_DEBUG (normal, NORMAL))
     {
+      char buf1[SU_ADDRSTRLEN];
+
       if (! CHECK_FLAG (peer->sflags, PEER_STATUS_ACCEPT_PEER))
 	zlog_debug ("%s open active, local address %s", peer->host,
 		    sockunion2str (peer->su_local, buf1, SU_ADDRSTRLEN));

bgpd/bgp_network.c

diff --git a/bgpd/bgp_network.c b/bgpd/bgp_network.c
index a7dca53..73234fe 100644
--- a/bgpd/bgp_network.c
+++ b/bgpd/bgp_network.c
@@ -185,7 +185,7 @@
     zlog_debug ("[Event] Make dummy peer structure until read Open packet");
 
   {
-    char buf[SU_ADDRSTRLEN + 1];
+    char buf[SU_ADDRSTRLEN];
 
     peer = peer_create_accept (peer1->bgp);
     SET_FLAG (peer->sflags, PEER_STATUS_ACCEPT_PEER);